Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345324 - CheckboxMultiSelectAttributeEditor should only call attributeChanged once per change
Summary: CheckboxMultiSelectAttributeEditor should only call attributeChanged once per...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.6   Edit
Assignee: Sam Davis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 15:16 EDT by Sam Davis CLA
Modified: 2015-03-24 16:37 EDT (History)
1 user (show)

See Also:

Attachments
patch (1.65 KB, patch)
2011-05-10 15:16 EDT, Sam Davis CLA 		steffen.pingel: iplog+
Details | Diff
mylyn/context/zip (3.53 KB, application/octet-stream)
2011-05-16 14:42 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2011-05-10 15:16:14 EDT 
The buttonPressed method calls setValues and then attributeChanged, but setValues itself calls attributeChanged, resulting in duplicate notification. buttonPressed should not directly call attributeChanged.
Comment 1 Sam Davis CLA 2011-05-10 15:16:48 EDT 
Created attachment 195265 [details]
patch

Steffen, here's a small patch.
Comment 2 Steffen Pingel CLA 2011-05-10 16:14:25 EDT 
Thanks. I'll look at the patch in the next couple of days.
Comment 3 Steffen Pingel CLA 2011-05-16 14:42:34 EDT 
Thanks Sam. I have applied the patch.
Comment 4 Steffen Pingel CLA 2011-05-16 14:42:36 EDT 
Created attachment 195777 [details]
mylyn/context/zip