Community
Participate
Working Groups
Build Identifier: I20110310-1119 Delete confirmation doesn't provide complete information Reproducible: Always Steps to Reproduce: - open JPA diagram editor - right click "Show All Entities" or drag and drop an entity from project explorer - now, select an entity and delete With respect to the "show entity..." I was expecting the delete operation would remove ONLY the rendering of the entity on the editor. Instead the delete removes the entity from the project (deletes the java file and entry from persistence.xml file). The confirmation message for delete provides only "Do you really want to delete?" I feel this isn't provide enough information. It would be useful to provide little more information like "Are you sure to delete <entity-name> from the project and update persistence.xml?"
Yes, I guess the confirmation message might be confusing. It won't hurt to make it more clear.
Created attachment 195969 [details] Added detailed delete information when deleting one or more entities or a relation
Created attachment 195999 [details] patch v2 The original patch is fine, I just made a little adjustments.
This patch is not critical, but is relatively small, so I believe it should get into RC2. No workaround. The fix has been tested manually and all the exisiting JUnit tests are passing successfully. The fix adds implementaion(s) of the inherited method getUserDecision(), which does nothing but to open a confirmation dialog and return false/true indicating if the user wants to proceed with deleting. The fix also makes confirmation questions a bit more detailed. I've reviewed the fix. The fix is relatively small and the risk is low.
I have been confused by this myself, and I suppose in a worst case scenario this could result in data loss. As a result, I think it meets the criteria for RC2.
sounds good for RC2
Patch committed in RC2
.
Verified in Build I-3.3.0RC4-20110603221533 Verified delete message within diagram editor appears as follows - Do you want to remove the entity "ADDRESS" from the diagram and delete the corresonding Java resouce "moel.ADDRESS"? See the link to view test steps for verification. http://wiki.eclipse.org/Dali_3.0_RC2
