Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345312 - Missing appropriate "Undo..." menu item name/label
Summary: Missing appropriate "Undo..." menu item name/label
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: Diagram Editor (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Krum Bakalsky CLA
QA Contact: Stefan Dimov CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 14:30 EDT by Ram Venkataswamy CLA
Modified: 2011-11-01 18:28 EDT (History)
5 users (show)

See Also:
david_williams: pmc_approved+
stefan.dimov: pmc_approved? (raghunathan.srinivasan)
stefan.dimov: pmc_approved? (naci.dai)
stefan.dimov: pmc_approved? (deboer)
stefan.dimov: pmc_approved? (neil.hauge)
stefan.dimov: pmc_approved? (kaloyan)
stefan.dimov: pmc_approved? (cbridgha)
stefan.dimov: review+
neil.hauge: review+

Attachments
Patch proposal (27.71 KB, patch)
2011-05-18 10:45 EDT, Krum Bakalsky CLA 		no flags Details | Diff
Removing some unnecessary changes from my dirty workspace (21.51 KB, patch)
2011-05-18 10:54 EDT, Krum Bakalsky CLA 		neil.hauge: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ram Venkataswamy CLA 2011-05-10 14:30:50 EDT 
Build Identifier:  I20110310-1119

Missing appropriate "Undo..." menu item name/label

Reproducible: Always

Steps to Reproduce:
- open JPA Diagram editor

- right click on the editor "Show all entities"

- now, right click on editor and notice the undo menu item

"Undo org.eclipse.jpt.jpadiagrameditor.ui.internal.feature.AddAllEntiesFeature"

Suggestion: Instead it should be a readable message like "Undo Show All Entities"
Comment 1 Krum Bakalsky CLA 2011-05-18 10:45:26 EDT 
Created attachment 195978 [details]
Patch proposal

The AbstractCustomFeature class from Graphiti provides the getName() method, which is used for displaying the feature name.
Comment 2 Krum Bakalsky CLA 2011-05-18 10:45:47 EDT 
Hi Ram,

Thanks for reporting this bug, your observation definitely makes sense.
@Stefan: I have proposed a patch, the JUnit tests run fine. Could you please take a look at it ?


Kindest Regards,
Krum.
Comment 3 Krum Bakalsky CLA 2011-05-18 10:54:51 EDT 
Created attachment 195983 [details]
Removing some unnecessary changes from my dirty workspace
Comment 4 Stefan Dimov CLA 2011-05-18 12:34:00 EDT 
The bug is not critical, but it's annoying to see some obviously incorrect texts.

There is no workaround.

The fix was tested manually and all the exisiting JUnit tests are passing successfully.

The patch may seem relatively big, but actually all it does is to implement in about fifteen different features the method getName(), which provides the necessary text to the framework. I've reviewed the fix.

The impact of the fix is little, so the risk is low.
Comment 5 Neil Hauge CLA 2011-05-18 15:02:49 EDT 
This is a UI change, but fixes an ugly scenario.  Also and adopter requested fix.  Fix is trivial.
Comment 6 Stefan Dimov CLA 2011-05-18 17:42:31 EDT 
On a very strict level, it's an UI change, but actually it changes the text of already existing context menu item ...
Comment 7 Tran Le CLA 2011-05-19 15:34:07 EDT 
Patch committed in RC2
Comment 8 Neil Hauge CLA 2011-05-19 16:00:15 EDT 
.
Comment 9 Jolene Moffitt CLA 2011-06-14 12:34:14 EDT 
Verified in Build I-3.3.0RC4-20110603221533

Verified appropriate Undo text appears in diagram editor.  See the link to view test steps for verification. http://wiki.eclipse.org/Dali_3.0_RC2