Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345306 - [client] git repo page - does it need checkboxes?
Summary: [client] git repo page - does it need checkboxes?
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 13:36 EDT by Susan McCourt CLA
Modified: 2011-09-01 11:42 EDT (History)
1 user (show)

See Also:
Szymon.Brandys: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-05-10 13:36:10 EDT
If we don't have selection based actions in the git repo page, can we turn off the checkboxes?  Alternatively, we need some margin between the checkbox and the repo location text.
Comment 1 Szymon Brandys CLA 2011-05-11 08:26:51 EDT
I think that Delete may be a selection based action. We plan to add it during M8. Gosia, I would mark it as INVALID once we have Delete on the repo view.
Comment 2 Malgorzata Janczarska CLA 2011-05-11 10:27:41 EDT
(In reply to comment #1)
> I think that Delete may be a selection based action. We plan to add it during
> M8. Gosia, I would mark it as INVALID once we have Delete on the repo view.
Yes, I added the multiselection when for a while we has "Delete" mock action. Soon it will be needed again ;)
Comment 3 Susan McCourt CLA 2011-05-11 12:54:43 EDT
cool, (don't forget some spacing!)  that is what caught my eye.
Comment 4 Malgorzata Janczarska CLA 2011-05-25 10:55:42 EDT
The delete command was added and now there is no doubt that we need checkboxes.
Comment 5 Susan McCourt CLA 2011-06-07 23:14:00 EDT
do we really need multi-select delete command?  
- it's only relevant for top level repos
- it already appears in the actions column
- it appears in the toolbar as an icon which is not our standard

Couldn't we just contribute it for "object" scope so it appears only in the column on relevant entries?  

And if we don't need that command, can we lose the checkboxes?

The reason I'm harping on this is that you have to get really deep in the clones tree to do anything, and the checkboxes become visual clutter.  (At least in the navigator you can drill in at each level so it's rare to have more than a level or so expanded...not to mention that move/copy and other parameterized actions would be very tedious without grouping them.)
Comment 6 Szymon Brandys CLA 2011-06-08 04:45:11 EDT
(In reply to comment #5)
> do we really need multi-select delete command?  
> - it's only relevant for top level repos

We could delete multiple branches or remotes too.

> - it already appears in the actions column

'Delete' in the navigator also appears twice, in the object toolbar and the main toolbar.

> - it appears in the toolbar as an icon which is not our standard

That's another bug. Gosia, please raise a separate bug for it and fix it.
Comment 7 Susan McCourt CLA 2011-06-08 10:30:20 EDT
(In reply to comment #6)
> (In reply to comment #5)
> > do we really need multi-select delete command?  
> > - it's only relevant for top level repos
> 
> We could delete multiple branches or remotes too.

I only saw the delete button appear when selecting the top level repo (in the latest code pulled last night).

> > - it already appears in the actions column
> 
> 'Delete' in the navigator also appears twice, in the object toolbar and the
> main toolbar.

Yes, only because we already have the menu for move/copy.  Move copy is not practical for single selection because you have to specify a target each time.

> 
> > - it appears in the toolbar as an icon which is not our standard
> 
> That's another bug. Gosia, please raise a separate bug for it and fix it.

I personally would prefer losing the checkboxes and the toolbar delete. You can always add them back if you expand the delete cases or add other multi select actions.
Comment 8 Malgorzata Janczarska CLA 2011-06-10 05:49:48 EDT
checkboxes removed.