Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345295 - [xtext.ui][hover] Hover information is computed twice
Summary: [xtext.ui][hover] Hover information is computed twice
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 12:20 EDT by Sebastian Zarnekow CLA
Modified: 2017-09-19 17:31 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Zarnekow CLA 2011-05-10 12:20:32 EDT
The jface framework uses ITextHover#getHoverRegion to determine region information that will be passed to ITextHoverExtension2#getHoverInfo2 in an own thread to make sure the ui is not blocked. Xtext's hover implementation uses #getHoverInfo2 to compute the result of #getHoverRegion which renders the framework's optimization strategy pointless. Even worse, the expensive computation of the actual hover data is performed twice, once in the ui thread and once in the computation thread.

For indigo, we can implement a workaround to reuse the computed information when #getHoverInfo2 is actually called from the computation thread, but we should really try to fix as it makes it really hard to compute quickfixes that are not trivial, e.g. for broken links to constructors or classes.
Comment 1 Holger Schill CLA 2012-03-23 06:27:53 EDT
Was already fixed.
Comment 2 Karsten Thoms CLA 2017-09-19 17:20:39 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 3 Karsten Thoms CLA 2017-09-19 17:31:57 EDT
Closing all bugs that were set to RESOLVED before Neon.0