Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345272 - update graphiti tutorial description
Summary: update graphiti tutorial description
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.8.0   Edit
Assignee: Michael Wenz CLA
QA Contact:
URL:
Whiteboard: Indigo RC1 theme_bugs
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 09:58 EDT by Bernhard Merkle CLA
Modified: 2011-06-24 08:43 EDT (History)
2 users (show)

See Also:
michael.wenz: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Merkle CLA 2011-05-10 09:58:13 EDT 
Build Identifier: 20110319-2305

bug in documentation: in Graphiti Developer Guide -> Tutorial -> Diagram you list the required plugins.

However I think the plugin org.eclipse.emf.transaction is also necessary and missing from the description 


Reproducible: Always
Comment 1 Michael Wenz CLA 2011-05-11 02:55:00 EDT 
Actually the reference to org.eclipse.emf.transaction is only needed for a later (rather exotic) extension of the turial (dark feature processing) and is not needed to start-off with the tutorial. For that reason we decided not to have this dependency in the initial list to keep references to a minimum.
I added a note regarding this both on the diagrams and the dark feature processing page in the tutorial description.

Thanks for pointing this out.

Michael
Comment 2 Bernhard Merkle CLA 2011-05-11 03:45:12 EDT 
another small thing:

//from the tutorial doc:

       // SHAPE WITH TEXT
        {
            // create shape for text
            Shape shape = peCreateService.createShape(containerShape, false);
            // create and set text graphics algorithm
            Text text = gaService.createDefaultText(shape, addedClass.getName());

createDefaultText() does not compile, I think the interface may have changed ?

I used 
	final Text text = gaService.createText(shape, addedClass.getName());

so the tutorial docs with source code need some update here...
Comment 3 Michael Wenz CLA 2011-05-11 05:00:19 EDT 
Correct, the API for this has changed, because of introducing management for fonts. This has already been updated in the head version in CVS.

Michael
Comment 4 Bernhard Merkle CLA 2011-05-11 05:31:13 EDT 
sorry, another small thing:

when implementing the UpdateFeature i get the following NPE:

I just followed the instructions under "Test: Update a EClass Name"
When I invoke the context menu in the PROJECT EXPLORER under EClasses
I get the following exception. Is this a bug ?

PS. should i post this first to the forum instead of bugzilla ? 

!MESSAGE java.lang.NullPointerException
!STACK 0
java.lang.NullPointerException
	at org.eclipse.graphiti.examples.common.RenameActionProvider.fillContextMenu(RenameActionProvider.java:57)
	at org.eclipse.ui.navigator.NavigatorActionService$2.run(NavigatorActionService.java:221)
Comment 5 Bernhard Merkle CLA 2011-05-11 05:32:50 EDT 

(In reply to comment #4)
> sorry, another small thing:
> 
> when implementing the UpdateFeature i get the following NPE:
> 
> I just followed the instructions under "Test: Update a EClass Name"
> When I invoke the context menu in the PROJECT EXPLORER under EClasses
> I get the following exception. Is this a bug ?
> 

as additional note: 
it also does not work with the delivered example so I think there must be some bug
Comment 6 Michael Wenz CLA 2011-05-11 11:16:56 EDT 
Definitly a bug, it's fine to post it in bugzilla. But this should be a seperate bug report, because it has nothing to do with the original docu bug.

I filed another bugzilla for this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=345442

Michael
Comment 7 Michael Wenz CLA 2011-06-24 08:43:26 EDT 
Part of Graphiti Indigo 0.8.0