Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345232 - Refactor RWTRequestVersionControl
Summary: Refactor RWTRequestVersionControl
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.5 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 345395
Blocks: 342407
  Show dependency tree
 
Reported: 2011-05-10 04:28 EDT by Rüdiger Herrmann CLA
Modified: 2011-05-18 11:04 EDT (History)
0 users

See Also:

Attachments
Prelinimary fix (13.04 KB, patch)
2011-05-11 07:05 EDT, Rüdiger Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-05-10 04:28:31 EDT 
The main state that is held by RWTRequestVersionControl is the 'request-version', which exists once per session. However, the class has only static accessors and maintains its state in session attributes.
RWTRequestVersionControl could benefit from being transformed into a session singleton.
Comment 1 Rüdiger Herrmann CLA 2011-05-11 07:05:09 EDT 
Created attachment 195323 [details]
Prelinimary fix

This fix currently does not work because of bug 345395 and needs to be revised once the blocking bug is closed.
Comment 2 Rüdiger Herrmann CLA 2011-05-18 11:04:42 EDT 
Adjusted patch and applied it to CVS HEAD.