Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345198 - Add ability to specify image in sdef editor for connection elements in diagram element page
Summary: Add ability to specify image in sdef editor for connection elements in diagra...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Shenxue Zhou CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 16:20 EDT by Greg Amerson CLA
Modified: 2021-11-19 09:21 EST (History)
2 users (show)

See Also:

Attachments
Patch #1 (1.70 KB, patch)
2011-05-17 20:39 EDT, Greg Amerson CLA 		no flags Details | Diff
Patch #2 (2.05 KB, patch)
2011-05-17 20:53 EDT, Greg Amerson CLA 		shenxue.zhou: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Amerson CLA 2011-05-09 16:20:52 EDT 
In the sdef editor for diagram element page you can specify images that you want to use for node objects.  The same should be done for connections since they support same underlying ability.
Comment 1 Konstantin Komissarchik CLA 2011-05-09 16:32:36 EDT 
What image are you referring to here? The one that appears in the palette?
Comment 2 Greg Amerson CLA 2011-05-09 16:36:22 EDT 
I am talking about images for connections.  In the SDEF Editor you can specify images to be used for Objects or Nodes, but not for connections.  however, if you put a image element in the SDEF directly it is honored.  

<connection>
            <endpoint1>
                <type>none</type>
            </endpoint1>
            <endpoint2>
                <type>arrow</type>
            </endpoint2>
            <id>Relationship</id>
            <tool-palette-label>relationship</tool-palette-label>
            <tool-palette-image>
                <id>relationshipImage</id>
                <path>icons/references_16x16.png</path>
            </tool-palette-image>
        </connection>

You can't specify that <tool-palette-image> in the SDEF Form editor even though it works just fine.
Comment 3 Shenxue Zhou CLA 2011-05-09 16:56:40 EDT 
I may have missed exposing the connection image to the sdef editor.
Comment 4 Greg Amerson CLA 2011-05-17 20:39:24 EDT 
Created attachment 195929 [details]
Patch #1

This seems to work in my env.
Comment 5 Konstantin Komissarchik CLA 2011-05-17 20:44:16 EDT 
cough... header... cough
Comment 6 Greg Amerson CLA 2011-05-17 20:53:16 EDT 
Created attachment 195931 [details]
Patch #2

Rats, you would think I would have this process down by now :)
Comment 7 Konstantin Komissarchik CLA 2011-05-17 20:55:46 EDT 
Shenxue,

Tomorrow is IP log contribution deadline for Indigo. Please review and release this patch if appropriate no later than tomorrow.

Greg,

Hate to curb the excitement, but we are in unfortunate position of not being able to accept any further patches for anything targeted for the 0.3 release. Don't want Eclipse Legal to be mad at us. You can still work on items targeted beyond the 0.3 release and if there is an item that you think can be deferred so that you can work on it, please make a note of that in the bug.
Comment 8 Greg Amerson CLA 2011-05-17 21:08:20 EDT 
No problem.  I wish I would have started back earlier than this week on my sapphire editors so I could have contributed a few more patches prior to 0.3.  I'll keep the bug reports coming regardless.
Comment 9 Shenxue Zhou CLA 2011-05-18 11:18:21 EDT 
Patch submitted. Thanks Greg!
Comment 10 Konstantin Komissarchik CLA 2011-05-18 11:24:30 EDT 
Shenxue,

You need to do one more step... Click on the details link next to the patch. Find iplog field and set it to "+". This will cause the patch to appear in Sapphire IP Log, which Eclipse Foundation Legal reviews every release.

http://www.eclipse.org/projects/ip_log.php?projectid=technology.sapphire
Comment 11 Ram Venkataswamy CLA 2011-06-02 18:53:57 EDT 
verified with build 0.3.0.201106021201
Comment 12 Konstantin Komissarchik CLA 2011-06-03 11:54:13 EDT 
Closing.