Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345191 - [client] [textmatestyler] Support begin/end patterns from TextMate grammars
Summary: [client] [textmatestyler] Support begin/end patterns from TextMate grammars
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 347589 347590
  Show dependency tree
 
Reported: 2011-05-09 15:39 EDT by Mark Macdonald CLA
Modified: 2011-09-01 11:42 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-05-09 15:39:59 EDT 
Orion 0.2M7

Need to support:
- "captures" -- for assigning scope to the matching groups of a "match" rule
- "begin/end" rules -- for matching constructs that span more than 1 line
  -- contentName, beginCaptures, endCaptures -- for assigning scope to the start & stop delimiters of a begin/end rule
Comment 1 Mark Macdonald CLA 2011-05-29 19:55:31 EDT 
I'm going to use this bug just for begin/end support, and open other bugs for the other stuff mentioned in Comment #0.
Comment 2 Mark Macdonald CLA 2011-05-29 20:10:40 EDT 
Opened:
 Bug 347589 for captures
 Bug 347590 for backreferences between end and begin regexes
Comment 3 Mark Macdonald CLA 2011-06-02 13:34:03 EDT 
This is in, but there are still issues with the damage/repair support when dealing with begin/end rules.

If the styles update wrongly as you type, but saving and reloading the editor (Ctrl+R) fixes them, then it's a bug in the repairer.

If reloading the editor doesn't fix the styles, then either the rule-applying algorithm is wrong, or the HTML highlighting rules are wrong.


Initial commit:
http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=945af0ffd293e076643f00cb7b556b7e832ebe4b