Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345187 - generate equinox incubator source bundles
Summary: generate equinox incubator source bundles
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 15:35 EDT by Kim Moir CLA
Modified: 2012-03-23 15:06 EDT (History)
2 users (show)

See Also:
tjwatson: review+


Attachments
patch (80.48 KB, patch)
2011-05-11 10:53 EDT, Kim Moir CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Moir CLA 2011-05-09 15:35:48 EDT
The are not currently generated in the build
Comment 1 Kim Moir CLA 2011-05-09 15:37:06 EDT
Tom, you asked for equinox incubator source bundles in bug 342997. Do you just want them to appear as individual bundles along with the rest of the incubator bundles.  Is this an item for 3.7?
Comment 2 Thomas Watson CLA 2011-05-09 16:27:27 EDT
(In reply to comment #1)
> Tom, you asked for equinox incubator source bundles in bug 342997. Do you just
> want them to appear as individual bundles along with the rest of the incubator
> bundles.  Is this an item for 3.7?

At this point, what ever is the most simple for you at this point.

- individual downloads
- single incubator SDK zip that contains all incubator bundles
- ???

It would be great if we could get this for 3.7, but I hope you can get it placed somewhere relatively easily.  Let me know if that is not true.
Comment 3 Kim Moir CLA 2011-05-09 17:33:13 EDT
How about a single incubator zip with all the binary and source bundles?  Here is what we have today:
			
org.eclipse.equinox.initializer_1.0.0.v20100503.jar
org.eclipse.equinox.console.supportability_1.0.0.v20110207.jar
org.eclipse.equinox.region_1.0.0.v20110503.jar
equinox-jmx-common-I20110509-1200.zip
equinox-jmx-client-I20110509-1200.zip
equinox-jmx-server-I20110509-1200.zip

I would imagine just including another zip, which included the org.eclipse.equinox.initializer, org.eclipse.equinox.console.supportability and 
org.eclipse.equinox.region binary and source bundles. Does that sound okay to you?
Comment 4 Thomas Watson CLA 2011-05-10 09:58:08 EDT
(In reply to comment #3)
> How about a single incubator zip with all the binary and source bundles?  Here
> is what we have today:
> 
> org.eclipse.equinox.initializer_1.0.0.v20100503.jar
> org.eclipse.equinox.console.supportability_1.0.0.v20110207.jar
> org.eclipse.equinox.region_1.0.0.v20110503.jar
> equinox-jmx-common-I20110509-1200.zip
> equinox-jmx-client-I20110509-1200.zip
> equinox-jmx-server-I20110509-1200.zip
> 
> I would imagine just including another zip, which included the
> org.eclipse.equinox.initializer, org.eclipse.equinox.console.supportability and 
> org.eclipse.equinox.region binary and source bundles. Does that sound okay to
> you?

That would be great.  Thanks Kim.
Comment 5 Kim Moir CLA 2011-05-10 10:13:00 EDT
Where do you want me to to create the feature for this?  I notice the incubator bundles are all in different subdirectories. I would guess incubator/features would be a good location?
Comment 6 Thomas Watson CLA 2011-05-10 10:33:47 EDT
(In reply to comment #5)
> Where do you want me to to create the feature for this?  I notice the incubator
> bundles are all in different subdirectories. I would guess incubator/features
> would be a good location?

yes, I think that would be a good location.  Thanks.
Comment 7 Kim Moir CLA 2011-05-11 10:53:49 EDT
Created attachment 195364 [details]
patch

Patch to generate equinox incubator source bundles.  Also, I added an feature for these bundles in monitoring\bundles\org.eclipse.equinox.incubator.feature.
Comment 8 Kim Moir CLA 2011-05-11 10:56:28 EDT
Tom, I've verified this fix in a test build.  It generates the source bundles for the incubator bundles. Can you approve this fix.

I'm still working on generating the source bundles for the jmx features that are included in the new org.eclipse.equinox.incubator.feature.  These weren't generated before.
Comment 9 Thomas Watson CLA 2011-05-11 14:57:04 EDT
(In reply to comment #7)
> Created attachment 195364 [details]
> patch
> 
> Patch to generate equinox incubator source bundles.  Also, I added an feature
> for these bundles in monitoring\bundles\org.eclipse.equinox.incubator.feature.

I would have thought this feature would be placed under incubator/features/ but in the end it does not matter much to me.
Comment 10 Kim Moir CLA 2011-05-11 15:09:32 EDT
Yes, I tried to check out all of incubator to add a features directory but it was taking an hour to do so. (Lots of image files in some of the bundles). So that's why it's where it is today....perhaps we can move it later.
Comment 11 Thomas Watson CLA 2011-05-11 15:17:43 EDT
(In reply to comment #10)
> Yes, I tried to check out all of incubator to add a features directory but it
> was taking an hour to do so. (Lots of image files in some of the bundles). So
> that's why it's where it is today....perhaps we can move it later.

Later, as in when we are using git and it is easy to do ;-)

OK, this is fine. Lets move forward.  Thanks Kim!
Comment 12 Kim Moir CLA 2012-03-23 14:50:54 EDT
Not sure if this is still an issue, Tom are there still equinox incubator bundles?
Comment 13 Thomas Watson CLA 2012-03-23 15:06:48 EDT
(In reply to comment #12)
> Not sure if this is still an issue, Tom are there still equinox incubator
> bundles?

We don't currently build anything in the incubator.  I closed this as wontfix.