Community
Participate
Working Groups
We are going to start putting I-builds on orion.eclipse.org, which I think is great. I think we are going to want a way to show the build id of a running Orion, because we are potentially going to get confusion between what is running at orionhub, what is on orion.eclipse.org, what we are self-hosting with, etc. I can add UI for this if someone can set up the build so that this information is available.
Where do we want the build id? I can stick add it as a system property via the config.ini, but that would then require server API to get it. Or, I can do some replacement on some html/js file somewhere so it is available directly in the client. I can also just completely generate an entire js file that contains just something like var eclipse = eclipse || {}; eclipse.buildId = 0.2.0.20110509-1200 (or orion, we seem to be mixed in the namespace we are using)
One approach would be to just have an "about" page. We could have a link to it in the UI, or just leave it as a magic URL. The Eclipse help system has a generic about servlet that we could probably "borrow". See here for example: http://help.eclipse.org/helios/about.html
looking at that page got me to thinking...maybe we could just hijack the plug-in registry page. There's very little on that page today. We could put the build id and over time if there was other system info that was important, we could keep it there until that page got too crowded.
Note that since we are now running the help system, their about servlet is available to us: http://orion.eclipse.org/about.html This might be good enough for now.
(In reply to comment #4) > Note that since we are now running the help system, their about servlet is > available to us: > > http://orion.eclipse.org/about.html > > This might be good enough for now. I don't think it's good enough unless we can include a fake plug-in in the build that will appear at the top of the list. Running orion.eclipse.org, the about page shows a bunch of logback, apache, etc. plug-ins first. When I open the page I don't see any plugin id's that look like an Orion I-build. So I have to scroll way down until I find an orion plugin with a version number that looks right. I think at a minimum we need to put in a plug-in that will show up first, or else we hook into the servlet and show an overall build id in the about page.
Created attachment 196375 [details] screenshot. What's the build version?
Where this bug goes depends on how it is fixed. My current thinking is to update AboutServlet in help to include this information, since it would be useful information in that context too.
*** Bug 361582 has been marked as a duplicate of this bug. ***
The first problem is that the Orion server download doesn't contain a build Id at all. Here is a builder change to add the build id to the config.ini like we do in Eclipse SDK: http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=f6ea8828042e9417beaa1f589b84b31f58e107d9
Previous fix wasn't quite right. Here is a new builder fix to add the build id as a system property: http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=51b2dfa30343be18baa5859c3cbe6594c7fd17b1 I ran a test build and verified it worked.
The build id now appears in the "About Orion" page.
Verified in I20120425-1430.
