Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345143 - Inconsistent parameter type for checks on tabbed panes
Summary: Inconsistent parameter type for checks on tabbed panes
Status: CLOSED WONTFIX
Alias: None
Product: Jubula
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Oliver Goetz CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 10:02 EDT by Felix Ziesel CLA
Modified: 2013-12-17 07:40 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Ziesel CLA 2011-05-09 10:02:43 EDT
In unbound modules are the following test steps for checking existence and enablement of tabs:

1. ub_tpn_checkExistenceOfTab_byValueOrIndex (String)
2. ub_tpn_checkEnablementOfTab_byIndex (Integer)
3. ub_tpn_checkEnablementOfTab_byValue (String)

if I want to use the integer parameter in a module I have to provide to parameters of the same value (one for Integer, one for String).
Every change has to be done twice.

It would be better to split the first step in two: 
1.a. ub_tpn_checkExistenceOfTab_byValue (String)
1.b. ub_tpn_checkExistenceOfTab_byIndex (Integer)

This way I can also avoid problems with tabs that has a number as name.
Comment 1 Alexandra Schladebeck CLA 2011-05-09 10:07:21 EDT
Another alternative would be to join the modules that currently use just index or just value so that they also act with either. We made the decision to go this way for new modules (e.g. table headers) a while ago to keep the libraries "slimmer". 

Tabs which have numbers as names should be able to be addressed using the operator "matches" like so: .*12345.* or '12345'. "12345" is then interpreted as a string, not an integer. 

Another possibility would be to make String and Integer parameters compatible with each other.
Comment 2 Felix Ziesel CLA 2011-05-09 10:28:00 EDT
(In reply to comment #1)
> Another alternative would be to join the modules that currently use just index
> or just value so that they also act with either. We made the decision to go
> this way for new modules (e.g. table headers) a while ago to keep the libraries
> "slimmer". 
> 
> Tabs which have numbers as names should be able to be addressed using the
> operator "matches" like so: .*12345.* or '12345'. "12345" is then interpreted
> as a string, not an integer. 
> 
> Another possibility would be to make String and Integer parameters compatible
> with each other.

This is another possibility. But I think the test developer should make a decision if he want to use the index or the value. The .*-Solution smells a little bit like workaround for me ;-)
Comment 3 Alexandra Schladebeck CLA 2013-12-13 09:01:30 EST
I still agree that this is a change that we might want to do, but I don't see us doing it in the near future. Marking as wontfix. If anyone has other / new arguments, please reopen.
Comment 4 Oliver Goetz CLA 2013-12-17 07:40:14 EST
Closed due to comment 3