Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345076 - Can't commit file with only file permission change.
Summary: Can't commit file with only file permission change.
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-08 13:37 EDT by Fredrik Henrysson CLA
Modified: 2013-01-01 09:58 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fredrik Henrysson CLA 2011-05-08 13:37:17 EDT 
Build Identifier: 20110218-0911

If a file with only a permission change is staged for commit it can't be commited. Will fail with internal error: No Changes.

After staging the file in Eclipse the terminal based git describes the changes as following:

% git diff --cached
diff --git a/script.py b/script.py
old mode 100644
new mode 100755


Reproducible: Always

Steps to Reproduce:
1. Take a file that is already added.
2. Change executable flag on the file
3. Add file to commit
4. Commit file.
Comment 1 Matthew Webber CLA 2011-12-07 11:49:00 EST 
The underlying cause for this has been reported as:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=361570
DiffEntry.scan() does not report executable bit only difference
Comment 2 Robin Rosenberg CLA 2011-12-16 11:41:56 EST 
Patch at http://egit.eclipse.org/r/4851
Comment 3 Robin Rosenberg CLA 2011-12-16 11:42:29 EST 
(In reply to comment #1)
> The underlying cause for this has been reported as:
> 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=361570
> DiffEntry.scan() does not report executable bit only difference

As mentioned there, the bug is elsewhere. See patch.
Comment 4 Robin Rosenberg CLA 2012-01-13 05:30:23 EST 
Submitted d5c890e0fdbfdd5d532121a2eb812ee2143c8ab5
Comment 5 Mykola Nikishov CLA 2012-03-03 11:12:24 EST 
[Batch change] Remove passed Target Milestones

If anyone on CC list is going to fix/implement this, feel free to assign a new, post-1.3/2.0, target milestone.
Comment 6 Robin Rosenberg CLA 2013-01-01 09:58:53 EST 
(comment#4)