Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345041 - no event fired when Unmatched container is created
Summary: no event fired when Unmatched container is created
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-06 19:07 EDT by Thomas Ehrnhoefer CLA
Modified: 2011-05-16 15:39 EDT (History)
2 users (show)

See Also:


Attachments
patch v1 (985 bytes, patch)
2011-05-06 19:20 EDT, Thomas Ehrnhoefer CLA
no flags Details | Diff
mylyn/context/zip (7.34 KB, application/octet-stream)
2011-05-06 19:20 EDT, Thomas Ehrnhoefer CLA
no flags Details
patch v2 (1.25 KB, patch)
2011-05-06 19:32 EDT, Thomas Ehrnhoefer CLA
no flags Details | Diff
mylyn/context/zip (4.79 KB, application/octet-stream)
2011-05-06 19:32 EDT, Thomas Ehrnhoefer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2011-05-06 19:07:23 EDT
Usually the tasklist fires events on container creation. It appears though there is no event when a query got changed in a way that an Unmatched container is created (and did not exist before).
Comment 1 Thomas Ehrnhoefer CLA 2011-05-06 19:20:47 EDT
Created attachment 194996 [details]
patch v1

adds a ROOT delta if tasks get added to an empty orphan container (similar to the unmatched in addTask)
Comment 2 Thomas Ehrnhoefer CLA 2011-05-06 19:20:48 EDT
Created attachment 194997 [details]
mylyn/context/zip
Comment 3 Thomas Ehrnhoefer CLA 2011-05-06 19:32:38 EDT
Created attachment 194998 [details]
patch v2

guess the same event should get thrown once the last task is removed from the unmatched. added this to the patch
Comment 4 Thomas Ehrnhoefer CLA 2011-05-06 19:32:39 EDT
Created attachment 194999 [details]
mylyn/context/zip
Comment 5 Thomas Ehrnhoefer CLA 2011-05-16 13:21:55 EDT
Shawn recently explained to me that the tasklist just hides those containers when empty...so I guess this could be treated as wontfix/invalid.
Comment 6 Steffen Pingel CLA 2011-05-16 14:52:50 EDT
Looking at TaskList.addUnmatchedContainer() there are indeed no events generated for the Unsubmitted and Unmatched containers when new repositories are added which does not seem right (even though containers are initially empty). I believe that the suggested patch is not correct though as it fires an event when items are added and not when the containers are added. That said I'm happy to consider a fix if you want to iterate on it again and add a test case. Note that we would the contribution by tomorrow to consider it for Mylyn 3.6.
Comment 7 Thomas Ehrnhoefer CLA 2011-05-16 15:39:34 EDT
Since we need this right away, we solved it on a different level, which also solves the use case of a new repository being added. I doubt I will be able to work on a patch for this anytime soon now, sorry.
Comment 8 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn