Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345033 - [client] Improve the find feature in the editor
Summary: [client] Improve the find feature in the editor
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.3   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2011-05-06 16:35 EDT by Felipe Heidrich CLA
Modified: 2011-10-20 16:40 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felipe Heidrich CLA 2011-05-06 16:35:55 EDT
I think the find (ctrl+f) could be better. Personally I would like to see mmost of the features we have in the Java Editor in Eclipse available to the Orion Editor.


- Do not close find dialog automatically when the user start the search
- Find / Replace (Bug 344071) 
- Backward and Forward search
- Case sensitive on /off
- Whole word on / off
- Wrap search on / off
Comment 1 Mark Macdonald CLA 2011-05-06 17:02:55 EDT
> - Do not close find dialog automatically when the user start the search
> - Case sensitive on /off
> - Whole word on / off
> - Wrap search on / off
I agree, and I think we need a proper Find dialog where you can set these options. We should also have a "Regex on/off" option, since it is awkward to type in a JS-style /regex/flags literal.

> - Backward and Forward search
We do actually support this (Ctrl+K and Ctrl+Shift+K) but you'd never find it unless you knew the hotkeys.
Comment 2 Boris Bokowski CLA 2011-05-06 21:16:10 EDT
If we're implementing this, we should try to avoid a dialog and use a more subtle UI like in Firefox or Chrome.
Comment 3 Felipe Heidrich CLA 2011-05-08 21:34:05 EDT
I agree with Mark and Boris commints, should add

>> - Backward and Forward search
>We do actually support this (Ctrl+K and Ctrl+Shift+K) but you'd never find it
unless you knew the hotkeys.

You can (and should) keep the shortcut  (Ctrl+K and Ctrl+Shift+K), Backward and Forward buttons in the dialog can apply only for the default button of the dialog.


Boris:
Yes, remove the dialog that is being used now. Just don't be too
subtle. I understand that is personal test, but in my opnion
--our current incremental search is too subtle (hard to read/see)
--the way safari implemented their search I think it is a great example how to be subtle and high usability.
Comment 4 libing wang CLA 2011-10-20 16:40:24 EDT
already fixed.