Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345020 - [run control][debug view] Run control actions not updated upon state change when multiple elements selected in Debug view.
Summary: [run control][debug view] Run control actions not updated upon state change w...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 3.7.1   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-06 15:37 EDT by Pawel Piech CLA
Modified: 2011-08-08 12:22 EDT (History)
2 users (show)

See Also:
Michael_Rennie: review+

Attachments
Fix. (2.19 KB, patch)
2011-05-06 15:37 EDT, Pawel Piech CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2011-05-06 15:37:27 EDT 
Created attachment 194982 [details]
Fix.

This is a minor bug we discovered during our product testing.  To reproduce:

- Launch 2 java applications in debugger.
- Select both jvm elements (debug target) in Debug view.
- Select the suspend action.

Notice that both processes suspended, and both are still selected.  But now neither the run nor suspend actions are enabled.  If you re-select them, the resume action will become enabled.

The fix is to iterate over multi-selections in Debug view instead of ignoring them.
Comment 1 Pawel Piech CLA 2011-05-06 15:38:22 EDT 
I'm fine to wait with this till 3.8 unless someone thinks it's more urgent.
Comment 2 Michael Rennie CLA 2011-05-06 16:28:40 EDT 
+1 for waiting for 3.8.
Comment 3 Martin Oberhuber CLA 2011-07-21 08:06:52 EDT 
(In reply to comment #1)
> I'm fine to wait with this till 3.8 unless someone thinks it's more urgent.

I guess I'm "someone" here ... this fix seems simple and isolated, and we need it in our product, could it be integrated for 3.7.1 ?

CQ:WIND00268632
Comment 4 Pawel Piech CLA 2011-07-21 12:06:58 EDT 
I didn't want to make this change after RC1, but now that this fix has made it through our product test cycle I feel a lot more confident about it.  

Mike, could you look at it wrt 3.7 stream?
Comment 5 Michael Rennie CLA 2011-07-25 16:57:19 EDT 
+1 for 3.7.1. The fix works as expected.

I have applied the patch to HEAD and 3.7.1
Comment 6 Michael Rennie CLA 2011-08-08 12:22:20 EDT 
verified in I20110805-0800