Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345016 - [patch] Support Storage Editor Input for target definitions
Summary: [patch] Support Storage Editor Input for target definitions
Status: CLOSED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 344983
Blocks:
  Show dependency tree
 
Reported: 2011-05-06 15:02 EDT by Curtis Windatt CLA
Modified: 2019-09-18 10:23 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-05-06 15:02:47 EDT 
+++ This bug was initially created as a clone of Bug #344983 +++

Fix is available on bug 344983, but it caused an NPE and was deemed too risky for RC1 inclusion.


Build Identifier: I20110310-1119

When opened with unknown editor input the target definition editor will fail to open and display a NPE.
Currently IFileEditorInput and IURIEditorInput are supported.
e.g. Team history views will use other editor inputs. Probably sub types of IStorageEditorInput.
I'll attach two patch proposals.
The first very simple one will just prevent the NPE and inform the user.
The second patch proposal introduce support for any kind of IStorageEditorInput.
(incl. save behavior as described in IStorageEditorInput documentation)

Reproducible: Always

Steps to Reproduce:
1. open a target file from EGit history view
Comment 1 Eclipse Genie CLA 2019-09-18 10:23:31 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.