Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345014 - Adding API filters for bug 344914 doesn't trigger a build
Summary: Adding API filters for bug 344914 doesn't trigger a build
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-06 14:51 EDT by Olivier Thomann CLA
Modified: 2011-05-06 16:21 EDT (History)
1 user (show)

See Also:
Michael_Rennie: review+

Attachments
Proposed fix (945 bytes, patch)
2011-05-06 15:21 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2011-05-06 14:51:48 EDT 
I was adding api filters for the errors reported against org.eclipse.help.base and I didn't get a build to get rid of the errors after the filters were added.
Comment 1 Olivier Thomann CLA 2011-05-06 14:52:14 EDT 
If I rebuild the project manually, all errors are gone.
Comment 2 Olivier Thomann CLA 2011-05-06 15:21:42 EDT 
Created attachment 194978 [details]
Proposed fix

The flags for the resource should also check for IResourceDelta.CONTENT bit. Otherwise when the content of the file is changed, there is no rebuild.
Comment 3 Olivier Thomann CLA 2011-05-06 15:23:10 EDT 
Michael, please verify.

To reproduce the problem, you can use org.eclipse.help.base.
Edit the filters and remove some, no rebuild.
Then add all filters again and there is no rebuild.

With the fix applied, as soon as the content has changed, this is causing a rebuild of the project.
Comment 4 Michael Rennie CLA 2011-05-06 16:03:39 EDT 
+1 works as advertised.
Comment 5 Michael Rennie CLA 2011-05-06 16:21:55 EDT 
This is a regression from 3.5, we should fix it for 3.7.

Applied patch to HEAD.