Community
Participate
Working Groups
20110506 1) Starting in the Navigator, enter search term "foo" in the search field and hit enter 2) On the search results page, click "Save Search" 3) On the same page, enter another search term "bar" and hit enter 4) On the new search results page, click "Save Search" -> It saves the "foo" search again, instead of the "bar" search.
This is still an issue. Also, the search page neeeds the global commands header stuffs.
Weird, some of the globalCommands stuff is there, but not the "primary nav links" extension stuff. This could be another one of those race condition things? Simon, is there something we do on a page to ensure that certain plug-ins are installed?
Created attachment 197739 [details] diff Two things fixed: - this page apparently never had the pass done on it where we load the plugin registry first and then start loading services and global commands, etc. (In fact this page never before used the plugin registry). This wouldn't have mattered when the primary nav links were hard-coded. But once those moved to an extension (in M8), then this page no longer had the links. - the command that gets generated for save was never updated when the hash was updated for a new search query
adding review for John. You can review the attached diff. Or you can find a branch called bug344980. If you are looking at this on Friday and approve, could you please push it for me? If it's today I can push it.
http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=41a91f907e0c87355880c00618a09526c31dec5a Performed my first cross-branch merge with the Orion git UI! It's so cool that I could push this change but the author information still shows Susan.
