Description Laurent Goubet 2011-05-06 05:53:56 EDT

I have a workspace in which projects under several different VCS are mixed together : SVN, CVS, GIT. For the purpose of this bug, let's say that all of my projects have local changes (and thus, decorated with their little ">" to tell me I need to synchronize them with the repository.

If I create a working set in which I put a project under CVS, the ">" decorator will properly be propagated to the working set level so that I know something is not in sync.

If I put a new project with no VCS in this working set, it remains decorated.

However, if I include a new project that is under Git or SVN (or under my own implementation of a RepositoryProvider), the working set no longer gets decorated, even though it still includes a project, under CVS, that is itself decorated.

This behavior is due to org.eclipse.team.internal.ccvs.ui.CVSLightweightDecorator#isMappedToCVS() :

-------------------
private boolean isMappedToCVS(ResourceMapping mapping) {
    IProject[] projects = mapping.getProjects();
    boolean foundOne = false;
    for (int i = 0; i < projects.length; i++) {
        IProject project = projects[i];
        if (project != null) {
            RepositoryProvider provider = RepositoryProvider.getProvider(project);
            if (provider instanceof CVSTeamProvider) {
                foundOne = true;
            } else if (provider != null) {
                return false; <- even if we "foundOne", return false if any single one of the projects is not under CVS version control
            }
        }
    }
return foundOne;
}
-------------------

I do not know if this is a behavior that was implemented to avoid conflicts between different RepositoryProvider all providing their own decorators ... feel free to invalidate this enhancement request if such a conflict can happen. However, if there is no conflict in such cases ("first come, first serve" and only the first decoration is chosen) then I think the accurate behavior would be to propagate the decoration to working sets even if it contains projects under mixed repository providers.