Community
Participate
Working Groups
In order to reproduce this bug, I use the example : Open Ecore Tabular Editor Step to reproduce : 1/ Use the action Open Ecore Tabular Editor on a EPackage 2/ Hide a column 3/ Redo one time -> the column doesn't reappears 4/ Redo another time -> the column reappears We should do only one command for this action and not two!
Created attachment 195385 [details] Patch for Bug 344925 Hi Vincent, Since some actions where executed in two separated commands, this behavior was quite expected. I merged the command execution so that one action will always be executed in only one command. There was also a problem with the refresh of the table, which has been solved by enabling the modifications tracking on the tableInstance resource. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 195702 [details] Patch for Bug 344925 Non regression test Hi, Please find attached a non regression test for this bug. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Comment on attachment 195385 [details] Patch for Bug 344925 Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 657. The SVN diff matches a lot of lines that have not be modified, I hope that this will not break the SVN history.
Comment on attachment 195702 [details] Patch for Bug 344925 Non regression test There is a problem with this unit test: it does not fail even if the patch has not be applied. I cannot commit it.
Created attachment 195739 [details] Patch for Bug 344925 Non regression test Hi, Please find attached an updated version of the test which does fail if we go back to revision 656, and succeed on 657. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Comment on attachment 195739 [details] Patch for Bug 344925 Non regression test Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 658.
Comment on attachment 195385 [details] Patch for Bug 344925 The commit of this patch causes a regression: https://hudson.eclipse.org/hudson/job/emffacet-nightly/317/testReport/junit/org.eclipse.emf.facet.widgets.nattable.tests/NatTableShowHideColumnsAPITests/showHideColumnsDeselectAllTest/
Created attachment 195764 [details] Patxh to fix the regression on NatTableShowHideColumnsAPITests.showHideColumnsDeselectAllTest Here is a patch to fix the regression on Patxh to fix the regression on NatTableShowHideColumnsAPITests.showHideColumnsDeselectAllTest.
Comment on attachment 195764 [details] Patxh to fix the regression on NatTableShowHideColumnsAPITests.showHideColumnsDeselectAllTest I've committed this patch. (a) I, Gregoire Dupe, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features.
The regression has been fixed. We can then mark this bug as fixed.
This bug can be marked as closed.
