Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344919 - [cdt] Reuse CDT's Source Not Found Editor
Summary: [cdt] Reuse CDT's Source Not Found Editor
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Debug (show other bugs)
Version: 0.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.3.1   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-06 03:40 EDT by Anton Leherbauer CLA
Modified: 2011-05-09 01:49 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (15.10 KB, patch)
2011-05-06 03:51 EDT, Anton Leherbauer CLA 		aleherb+eclipse: iplog-
Details | Diff
Revised patch (19.23 KB, patch)
2011-05-06 07:04 EDT, Anton Leherbauer CLA 		aleherb+eclipse: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2011-05-06 03:40:23 EDT 
CDT's CSourceNotFoundEditor provides a button to locate a file and automatically create a source path mapping for it in the launch config.  That's very handy and should be available with the TCF Debugger as well.
Comment 1 Anton Leherbauer CLA 2011-05-06 03:51:52 EDT 
Created attachment 194906 [details]
Proposed patch

This patch adds an adapter interface ISourceNotFoundPresentation (similar to ISourcePresentation) which allows to customize the editor used for the source-not-found case.
tcf.cdt implements this adapter to return a slightly customized version of CDT's CSourceNotFoundEditor.
Comment 2 Anton Leherbauer CLA 2011-05-06 07:04:13 EDT 
Created attachment 194921 [details]
Revised patch

Fixed: Close editor if launch terminates.
Comment 3 Eugene Tarassov CLA 2011-05-06 13:20:18 EDT 
I think it is good to go. Looks great!
Comment 4 Anton Leherbauer CLA 2011-05-09 01:49:14 EDT 
Thanks for reviewing. Committed.