Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344883 - EditorSelectionDialog#promptForExternalEditor() leaks an image
Summary: EditorSelectionDialog#promptForExternalEditor() leaks an image
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 14:43 EDT by Markus Keller CLA
Modified: 2011-10-06 04:32 EDT (History)
2 users (show)

See Also:
daniel_megert: review+

Attachments
Fix (1.34 KB, patch)
2011-05-05 14:43 EDT, Markus Keller CLA 		daniel_megert: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-05-05 14:43:47 EDT 
Created attachment 194859 [details]
Fix

HEAD

EditorSelectionDialog#promptForExternalEditor() leaks an image. To reproduce, choose "Open With > Other... > Browse..." and select a program.


java.lang.Error
	at org.eclipse.swt.graphics.Device.new_Object(Device.java:859)
	at org.eclipse.swt.graphics.Resource.init(Resource.java:86)
	at org.eclipse.swt.graphics.Image.<init>(Image.java:492)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:289)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:227)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:205)
	at org.eclipse.ui.dialogs.EditorSelectionDialog.promptForExternalEditor(EditorSelectionDialog.java:376)
	at org.eclipse.ui.dialogs.EditorSelectionDialog$DialogListener.handleEvent(EditorSelectionDialog.java:498)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4163)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3752)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
	at org.eclipse.jface.window.Window.open(Window.java:801)
	at org.eclipse.ui.actions.OpenWithMenu$3.handleEvent(OpenWithMenu.java:212)
Comment 1 Dani Megert CLA 2011-05-06 02:59:07 EDT 
Good for RC1.
Comment 2 Markus Keller CLA 2011-05-06 05:22:26 EDT 
Fixed.
Comment 3 Remy Suen CLA 2011-05-06 07:17:53 EDT 
Thanks for catching and fixing this leak, Markus.
Comment 4 Markus Keller CLA 2011-05-17 06:29:47 EDT 
Verified in I20110512-2000.
Comment 5 Dani Megert CLA 2011-10-06 04:32:59 EDT 
This didn't make it into the 4.x stream. Cherry-picked now:
Commit df03199b653d305397b221b34d13892698dfb159