Bug 344832 – Layout doesn't appear to occur when the 'Outline' switches pages

Bug 344832 - Layout doesn't appear to occur when the 'Outline' switches pages


Summary:	Layout doesn't appear to occur when the 'Outline' switches pages

Status:	VERIFIED FIXED

Product:	Platform
Classification:	Eclipse
Component:	UI
Version:	4.1
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	4.2 M3
Assigned To:	Platform-UI-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates:	357970 (view as bug list)
Depends on:
Blocks:
	Show dependency tree

Reported:	2011-05-05 08:53 EDT by Remy Suen
Modified:	2011-10-26 14:11 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Screenshot depicting the problem in question. (4.75 KB, image/png) 2011-05-05 08:53 EDT, Remy Suen	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Remy Suen

2011-05-05 08:53:40 EDT

Created attachment 194823 [details]
Screenshot depicting the problem in question.

As can be seen from the screenshot, the tool bar seems to get drawn over top of the tab item's content as the suite() method's label has been cut of.

Comment 1 Eric Moffatt

2011-08-19 14:38:59 EDT

To repro:

Create a project with both a java class and a text file, open both.

Move the Sash to ensure that when the java file is active the toolbar is wrapped (below the tab area).

Switch to the text file, notice that the 'an outline is not available' is offset to account for the wrapped TB. Move the sash slightly and it adjusts to become correctly top-aligned.

Now switch back to the java file and you get the issue as described...

Comment 2 Eric Moffatt

2011-08-19 14:53:57 EDT

Bogdan, should the CTF be handling the size change or are we responsible for issuing a specific 'layour' here ?

Comment 3 Bogdan Gheorghe

2011-08-22 11:17:52 EDT

As discussed, if it turns out that we are setting a new control for the toolbar (ie. remove the old toolbar and then add a new one), then SWT should be handling the layout. If we are just adding/removing items to the existing toolbar (and not actually removing it), then UI needs to call a layout to update the tab folder.

Comment 4 Eric Moffatt

2011-09-26 11:29:16 EDT

Pushed in >20110926.

commit 66bc52ad4fb39acfd11c1f53dcde24aac3c57db0

Comment 5 Carolyn MacLeod

2011-09-26 12:02:04 EDT

Did you happen to test the scenario described in bug 358750 comment 2?

Comment 6 Chris Goldthorpe

2011-09-29 16:49:30 EDT

*** Bug 357970 has been marked as a duplicate of this bug. ***

Comment 7 Eric Moffatt

2011-10-26 14:11:36 EDT

Verified in I20111025-2000.