Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344827 - [Compatibility] NPEs in cool bar manager to trim code
Summary: [Compatibility] NPEs in cool bar manager to trim code
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 critical (vote)
Target Milestone: 4.1 RC1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 07:57 EDT by Paul Webster CLA
Modified: 2011-05-05 08:40 EDT (History)
1 user (show)

See Also:

Attachments
Fix NPEs, don't feed null into the system v01 (2.58 KB, patch)
2011-05-05 07:58 EDT, Paul Webster CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2011-05-05 07:57:45 EDT 
java.lang.NullPointerException
 	at org.eclipse.ui.internal.CoolBarToTrimManager.fill(CoolBarToTrimManager.java:633)
 	at org.eclipse.ui.internal.CoolBarToTrimManager.update(CoolBarToTrimManager.java:573)
 	at org.eclipse.ui.internal.WorkbenchWindow.updateActionBars(WorkbenchWindow.java:1625)
 	at org.eclipse.ui.internal.WWinActionBars.updateActionBars(WWinActionBars.java:113)

and

 java.lang.NullPointerException
 	at org.eclipse.jface.action.ContributionManager.itemAdded(ContributionManager.java:405)
 	at org.eclipse.jface.action.ContributionManager.insert(ContributionManager.java:317)
 	at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.addToManager(ToolBarManagerRenderer.java:879)
 	at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.processSeparator(ToolBarManagerRenderer.java:809)
 	at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.modelProcessSwitch(ToolBarManagerRenderer.java:787)
Comment 1 Paul Webster CLA 2011-05-05 07:58:44 EDT 
Created attachment 194816 [details]
Fix NPEs, don't feed null into the system v01
Comment 2 Paul Webster CLA 2011-05-05 08:31:53 EDT 
(In reply to comment #1)
> Created attachment 194816 [details]
> Fix NPEs, don't feed null into the system v01

Released this to HEAD, scheduled a build for 08:45 EDT
PW
Comment 3 Paul Webster CLA 2011-05-05 08:40:00 EDT 
A new build has started.
PW