Community
Participate
Working Groups
Checking the PHP Runtime feature, I can't understand why it "requires" the WST.xsl feature. This feature dependency seems to add unnecessary bloat for products which don't need it. Could that feature dependency be removed or am I missing something? In general, as a product builder I'd like the PHP runtime feature as small and slick as possible. I can add extra stuff myself by including extra features, but it's hard to strip down myself.
it will be great if you send a patch. Setting as P1. thanks!
I could probably help out with a patch next week. Here is a suggestion for concrete steps to take: 1. php-feature should not require xsl tooling at all (it's not really needed). See bug 271627 which is open for XSLT feature refactoring, in case the PHP community thinks that parts of XSLT are important ... but personally I think that whoever wants XSLT can install XSLT separately independent of PHP so there should be no feature requirement. 2. php-feature should not require "org.eclipse.wst.common.fproj" feature. IMO the "faceted project UI" is confusing and only useful with web appliation servers. For PHP though, the infrastructures for server deployment are different. The fproj.core bundle is auto-required via bundle dependency, that's sufficient... no need to require the frpoj feature / ui. 3. I'm also not sure why the wst.web_ui feature is required. It gives things like the Web perspective, static web project, and web server_ui feature. None of which are strictly needed for PHP projects, since they have the PHP Project type, PHP Perspective etc. All the needed webtools stuff is already included by bundle dependencies. Consumers who really want static web editing can install the webtools web_ui feature themselves separately. 4. On the Indigo repository, the php runtime feature should be offered and not the php sdk feature. 5. In order to still give access to source code, the PDE "source references" should be enabled in the build to add source references to MANIFEST.MF. All these steps together will make it much easier for the community to download and install PHP from Indigo, and much easier for product builders to include PDT in their products. Plus, it may help downstripping the PHP package a little bit (avoid SDK, avoid JDT, avoid unnecessary XSLT bits).
Created attachment 194926 [details] patch Actually since it's so easy, attached is a patch. I'm removing the fproj and web_ui dependencies from the feature only but not from the build.properties, to ensure that bundle dependencies can still be resolved. For the xsl feature, AFAIK that's nowhere needed at all so I'm removing it entirely. The patch is against the R2_2_WAVE_7_3 branch. Not sure whether that's the branch that's scheduled to go into Indigo.
thanks Martin! we will definitely look into it soon and try to integrate it to next versions...
thanks Martin! I have committed to head and will test it now.
after apply the patch to head,and then install it on eclipse 3.7m6,after simply testing,it works fine for me! Thanks again!
change status
Closing.
