Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344768 - [disassembly] The disassembly view does not respect current line color setting
Summary: [disassembly] The disassembly view does not respect current line color setting
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 17:21 EDT by Patrick Chuong CLA
Modified: 2011-05-05 03:23 EDT (History)
1 user (show)

See Also:

Attachments
patch (1.07 KB, patch)
2011-05-04 17:23 EDT, Patrick Chuong CLA 		pchuong: iplog-
Details | Diff
Committed fix (1.79 KB, patch)
2011-05-05 02:54 EDT, Anton Leherbauer CLA 		aleherb+eclipse: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Chuong CLA 2011-05-04 17:21:12 EDT 
The disassembly view doesn't use the current "Current line highlight" preference value under "General | Editors | Text Editors" preference, it always use the default value from this perference.
Comment 1 Patrick Chuong CLA 2011-05-04 17:23:55 EDT 
Created attachment 194773 [details]
patch

This patch is a simple swap of the editor preference sore and the dsf ui preference fore for the ChainedPreferenceStore object. Without this, the preference value is found in the dsf ui preference store within the ChainedPreferenceStore, which is always the default value.
Comment 2 Anton Leherbauer CLA 2011-05-05 02:54:12 EDT 
Created attachment 194794 [details]
Committed fix

Nice find!  I have committed a different fix in the preference initializer.  It was wrong from the beginning to set the editor default preferences in the DSF UI preference store.  Without that it works as expected.
Comment 3 Anton Leherbauer CLA 2011-05-05 02:54:53 EDT 
Fixed in HEAD.
Comment 4 CDT Genie CLA 2011-05-05 03:23:03 EDT 
*** cdt cvs genie on behalf of aleherbau ***
Bug 344768 - [disassembly] The disassembly view does not respect current line color setting

[*] DisassemblyPreferenceConstants.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/preferences/DisassemblyPreferenceConstants.java?root=Tools_Project&r1=1.3&r2=1.4