Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344751 - [editor] Implement full selection
Summary: [editor] Implement full selection
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Felipe Heidrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 14:33 EDT by Felipe Heidrich CLA
Modified: 2011-09-01 11:41 EDT (History)
2 users (show)

See Also:


Attachments
screen shot (56.65 KB, image/png)
2011-05-10 16:36 EDT, Boris Bokowski CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Felipe Heidrich CLA 2011-05-04 14:33:18 EDT
Implement full selection
Code editors usually look better with full selection.
(note that chrome is always full selection by default, all other browsers are not).
Comment 1 Silenio Quarti CLA 2011-05-06 15:45:06 EDT

*** This bug has been marked as a duplicate of bug 342973 ***
Comment 2 Silenio Quarti CLA 2011-05-06 15:46:08 EDT
Sorry marked the wrong bug as duplicate.
Comment 3 Silenio Quarti CLA 2011-05-06 15:47:51 EDT
Added new constructor option "fullSelection" which is true by default.

Fixed

http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=72cb95a23a0216ca2d89974ea81d212f30da002f
Comment 4 Boris Bokowski CLA 2011-05-10 16:35:56 EDT
Reopening for FF4 on the Mac.
Comment 5 Boris Bokowski CLA 2011-05-10 16:36:10 EDT
Created attachment 195274 [details]
screen shot
Comment 6 Boris Bokowski CLA 2011-05-10 16:36:47 EDT
This was with FF4.0.1 on Mac OS X 10.6.7.
Comment 7 Boris Bokowski CLA 2011-05-10 16:47:03 EDT
While you are at it, you may want to test the selection behaviour on Opera as well. Doesn't appear to work 100% - I sometimes get a few characters in the first selected line that should be selected but aren't, or characters that shouldn't be selected but are.
Comment 8 Silenio Quarti CLA 2011-05-11 12:45:14 EDT
(In reply to comment #4)
> Reopening for FF4 on the Mac.

This is a bug on FF4 (and 3.6).  FF is mapping the wrong system color to the CSS "Highlight" named color. Tried this HTML on Chrome, Opera, Safari and Firefox (on Mac) and Firefox is the only one that chooses NSColor.alternateSelectedControlColor instead of NSColor.selectedControlColor.

http://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSColor_Class/Reference/Reference.html#//apple_ref/occ/clm/NSColor/alternateSelectedControlColor


------------------------------------------------
<!DOCTYPE html>
<html>
<head>
</head>
<body>

<div style="width:300px;height:300px;background:Highlight;">
What color is this div?
</div>

</body>
</html>
------------------------------------------------
Comment 9 Boris Bokowski CLA 2011-05-11 13:55:41 EDT
I guess we should file a bug on the Firefox side?
Comment 10 Silenio Quarti CLA 2011-05-11 14:03:08 EDT
I opened

https://bugzilla.mozilla.org/show_bug.cgi?id=656378

in the mean time we will see if we can come up with a workaround for this.
Comment 11 Felipe Heidrich CLA 2011-05-12 17:03:13 EDT
fixed Firefox on the mac
http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=c8067662dc6ba334e5cb628e0b778233dfb524f5

the problem with Opera is something else.