Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344731 - DS File wizard has confusing error
Summary: DS File wizard has confusing error
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 13:02 EDT by Curtis Windatt CLA
Modified: 2011-05-16 17:33 EDT (History)
1 user (show)

See Also:
ankur_sharma: review+

Attachments
Fix (6.05 KB, patch)
2011-05-04 13:35 EDT, Curtis Windatt CLA 		no flags Details | Diff
updated patch (6.48 KB, patch)
2011-05-05 04:22 EDT, Ankur Sharma CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-05-04 13:02:23 EDT 
1) Open new component wizard
2) Make sure a folder is selected
3) Make sure the file has a name
4) Have no value for the class
Result:
The wizard says the component must have a name.
Expected result:
The wizard says that a class must be specified
Comment 1 Curtis Windatt CLA 2011-05-04 13:35:12 EDT 
Created attachment 194744 [details]
Fix
Comment 2 Curtis Windatt CLA 2011-05-04 13:36:55 EDT 
Fixed in HEAD.  When you open the wizard we fill in example values.  If the user deletes the text, a more accurate error is returned.

Ankur, please review for RC1.
Comment 3 Ankur Sharma CLA 2011-05-05 04:22:55 EDT 
Created attachment 194801 [details]
updated patch
Comment 4 Ankur Sharma CLA 2011-05-05 04:25:59 EDT 
The patch is good. 
However, I noticed that when the filename has not been provided (and other entries are) then the message reads "Name can not be empty". This gets ambiguous as it is not referring to the Component 'Name' but the 'File Name'. I am attaching an updated patch which does this additional validation. See if it looks better.
Comment 5 Curtis Windatt CLA 2011-05-05 12:06:08 EDT 
The updated patch is fine by me.  Please review and commit it.
Comment 6 Ankur Sharma CLA 2011-05-08 05:49:47 EDT 
+1

Applied to HEAD
Comment 7 Curtis Windatt CLA 2011-05-16 17:33:11 EDT 
Verified in I20110514-0800