Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344704 - 'Paste Repository Path' command hijacks Ctrl+V forever
Summary: 'Paste Repository Path' command hijacks Ctrl+V forever
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 RC2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331240
  Show dependency tree
 
Reported: 2011-05-04 09:45 EDT by Remy Suen CLA
Modified: 2011-05-17 14:49 EDT (History)
2 users (show)

See Also:

Attachments
activate and de-activate v01 (3.70 KB, patch)
2011-05-17 14:48 EDT, Paul Webster CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-05-04 09:45:58 EDT 
After accessing the 'Git Repository Exploring' perspective, Ctrl+V will no longer paste stuff properly as it keeps trying to paste it as a repository path (for Git). Unbinding the command in the 'Keys' preference page will workaround this problem.
Comment 1 Paul Webster CLA 2011-05-04 09:57:30 EDT 
Hi Chris,

I see org.eclipse.egit.ui.internal.repository.RepositoriesView activates the context org.eclipse.egit.ui.RepositoriesView.

Do you know if anything else in egit.ui does?

It looks like we haven't tied our e4 context service activation/deactivation to core expressions in org.eclipse.ui.internal.contexts.ContextService.activateContext(String, Expression)

PW
Comment 2 Remy Suen CLA 2011-05-04 10:12:14 EDT 
Probably the same problem as bug 344698.
Comment 3 Paul Webster CLA 2011-05-17 14:48:56 EDT 
Created attachment 195904 [details]
activate and de-activate v01

If we are activating a context with an expression, make sure we honour the expression.

PW
Comment 4 Paul Webster CLA 2011-05-17 14:49:15 EDT 
Released to HEAD
PW