Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344683 - [server] Use LogCommand to get commits list
Summary: [server] Use LogCommand to get commits list
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P4 enhancement (vote)
Target Milestone: 0.2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard: gsoc2011
Keywords:
Depends on: 340049 346257
Blocks:
  Show dependency tree
 
Reported: 2011-05-04 06:06 EDT by Tomasz Zarna CLA
Modified: 2012-01-19 11:44 EST (History)
2 users (show)

See Also:
tomasz.zarna: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-05-04 06:06:41 EDT 
Whenever it's possible we should use JGit's porcelain API to work with a git repository. Keeping that in mind we could adjust GitCommitHandlerV1 to use org.eclipse.jgit.api.LogCommand.

It's a cosmetic change, it should have no effect on response content of /git/commit. All tests should pass without any modification.
Comment 1 Tomasz Zarna CLA 2011-06-06 05:28:44 EDT 
Piotrek any news here? Both blockers are fixed, so I guess we should be able to proceed. I even noticed that you have a branch for this bug on your github fork: https://github.com/pjanik/orion.server/commits/bug344683, does it contain anything ready for a review?
Comment 2 Piotr Janik CLA 2011-06-06 06:23:19 EDT 
Yes, branch https://github.com/pjanik/orion.server/commits/bug344683 is ready for review for a log time. I've just made rebase.

I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 3 Tomasz Zarna CLA 2011-06-06 08:59:30 EDT 
Szymon made some changes on bug 347134 that may interfere with what you have on your branch. I did rebase/merge your work and but got a test failure in GitLogTest#testLog. Please rebase it on your own and double check that. I've also added some comments on your code here: https://github.com/pjanik/orion.server/commit/75b380275e2870d769691ac7e38b2dd61bffb6b5. Please, reset review flag to "?" when done.
Comment 4 Piotr Janik CLA 2011-06-06 10:06:10 EDT 
I've applied your comments and rebased my work again. I've got no errors (All Server Test launch). 

https://github.com/pjanik/orion.server/commits/bug344683
Comment 5 Tomasz Zarna CLA 2011-06-06 10:29:34 EDT 
(In reply to comment #4)
> I've got no errors (All Server Test launch).

So I guess it was me messing up the merge. All tests pass here when pulled your latest change.

> https://github.com/pjanik/orion.server/commits/bug344683

Added one more comment there.
Comment 6 Piotr Janik CLA 2011-06-06 10:40:12 EDT 
I've applied small change to satisfy your comment. 

https://github.com/pjanik/orion.server/commits/bug344683
Comment 7 Tomasz Zarna CLA 2011-06-06 11:15:54 EDT 
(In reply to comment #6)
> I've applied small change to satisfy your comment.
Thanks! 

Fixed with http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=ff81d30f0f9af1e1bb9912c7ab742b7b307dc385.