Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344680 - Improve rendering of Tree#dispose
Summary: Improve rendering of Tree#dispose
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 1.5 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 05:58 EDT by Ralf Sternberg CLA
Modified: 2012-04-04 04:51 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2011-05-04 05:58:30 EDT 
The disposal of a Tree with many items already materialized results in long protocol messages.
But there seems to be no need to render a dispose call for every single TreeItem when the Tree is disposed. I'd suggest to check in the TreeItemLCA for the parent TreeItem (or the Tree if top-level) being disposed and if so, omit the dispose call. The client side can recursively dispose all child TreeItems.
Comment 1 Ivan Furnadjiev CLA 2012-04-04 04:51:12 EDT 
The implementation in TreeItemLCA#renderDispose was already there. Changed TreeItemAdapter#isParentDisposed to respect parent item as well. JUnit tests added. Changes are in CVS HEAD.