Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344657 - [patch] Folder file encoding not reverted when m-compiler-p config removed
Summary: [patch] Folder file encoding not reverted when m-compiler-p config removed
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: m2e (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 02:32 EDT by Anders Hammar CLA
Modified: 2021-04-19 13:22 EDT (History)
1 user (show)

See Also:

Attachments
Integration test showing bug (17.11 KB, patch)
2011-05-04 02:33 EDT, Anders Hammar CLA 		no flags Details | Diff
proposed fix (1.42 KB, patch)
2011-06-01 05:53 EDT, Anders Hammar CLA 		igor: iplog+
Details | Diff
integration test (17.11 KB, patch)
2011-06-01 05:54 EDT, Anders Hammar CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Hammar CLA 2011-05-04 02:32:30 EDT 
Build Identifier: 

I think there is a bug in the implementation for bug 340507, which is shown in the attached integration test.
In the case where the defined encoding is removed, the folder encoding should revert to container default (which it currently doesn't). The attached git patch for the integration tests adds a test which shows this.
I believe the simple solution is to apply the encoding to the IFolder even when
it's 'null', which means it's not defined in the Maven project.


Reproducible: Always

Steps to Reproduce:
1. Execute attached integration tests
Comment 1 Anders Hammar CLA 2011-05-04 02:33:07 EDT 
Created attachment 194666 [details]
Integration test showing bug
Comment 2 Anders Hammar CLA 2011-06-01 05:53:59 EDT 
Created attachment 197075 [details]
proposed fix

Attached fix for this bug
Comment 3 Anders Hammar CLA 2011-06-01 05:54:39 EDT 
Created attachment 197076 [details]
integration test
Comment 4 Igor Fedorenko CLA 2011-08-03 08:45:34 EDT 
Applied the patches. Thank you.
Comment 5 Denis Roy CLA 2021-04-19 13:22:53 EDT 
Moved to https://github.com/eclipse-m2e/m2e-core/issues/