Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344614 - [client] Open Resource dialog doesn't close when using keyboard
Summary: [client] Open Resource dialog doesn't close when using keyboard
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Andrew Clement CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 13:27 EDT by John Arthorne CLA
Modified: 2012-01-27 15:12 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-05-03 13:27:20 EDT
0.2 M7

- Open the editor
- Hit Ctrl+Shift+R to open resource
- Type in a file name
- Hit tab to switch focus to the first result in the list
- Hit enter

-> The new file opens, but the Open Resource dialog does not close
Comment 1 Andrew Clement CLA 2012-01-18 20:13:29 EST
This is fixed in this pull request: https://github.com/eclipse/orion.client/pull/15

Unfortunately the pull request is a bit messy as I get to grips with them on github.  Let me know if it needs more work.

===
I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 2 Andrew Clement CLA 2012-01-19 11:17:40 EST
ignore that pull request, I'm going to tidy it up before submitting it.
Comment 3 Andrew Clement CLA 2012-01-21 20:44:56 EST
I have created a new cleaner pull request that fixes this:

https://github.com/eclipse/orion.client/pull/16

I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 4 Andrew Clement CLA 2012-01-25 11:09:34 EST
Oops, I see you don't want pull requests.  Here is the same thing in another way:

git repo: git://github.com/aclement/orion.client.git
branch: bug344614
commit id: 02d6700c35fce60855c868f7abbddc050593a50a
full link: https://github.com/aclement/orion.client/commit/02d6700c35fce60855c868f7abbddc050593a50a

I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 5 Mark Macdonald CLA 2012-01-25 16:18:50 EST
(In reply to comment #4)
> Oops, I see you don't want pull requests.  Here is the same thing in another
> way:
> 
> git repo: git://github.com/aclement/orion.client.git
> branch: bug344614
> commit id: 02d6700c35fce60855c868f7abbddc050593a50a
> full link:
> https://github.com/aclement/orion.client/commit/02d6700c35fce60855c868f7abbddc050593a50a
> 
> I wrote all this code and have the rights to contribute it to Eclipse under the
> eclipse.org web site terms of use.

Looks good; pushed.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b16ea9cfcb0234ec30b357a6cd315309e68be55e

Thanks!