Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344587 - [client] Hit testing on syntax-highlighted html files is wrong
Summary: [client] Hit testing on syntax-highlighted html files is wrong
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 10:37 EDT by Mark Macdonald CLA
Modified: 2011-09-01 11:42 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-05-03 10:37:02 EDT 
Orion 0.2 M7

1. Load a large html file, ensure syntax highlighting is active
2. Scroll down
3. Try clicking on some lines with the mouse. Hit testing gets progressively worse the more you scroll down.

Perhaps the styles being applied by default-theme.css are somehow changing the line height, and throwing off the editor calculations?
Comment 1 Mark Macdonald CLA 2011-05-03 10:40:23 EDT 
(In reply to comment #0)
It seems to be the use of font-style:italic that really messes it up. If I take that out, hit testing feels OK.
Comment 2 Felipe Heidrich CLA 2011-05-03 10:58:40 EDT 
(In reply to comment #1)
> (In reply to comment #0)
> It seems to be the use of font-style:italic that really messes it up. If I take
> that out, hit testing feels OK.

Yes, Italic can do that.
Comment 3 John Arthorne CLA 2011-05-03 11:00:42 EDT 
Duplicate of bug 334910?
Comment 4 Mark Macdonald CLA 2011-05-03 11:37:51 EDT 

*** This bug has been marked as a duplicate of bug 334910 ***
Comment 5 Susan McCourt CLA 2011-05-04 12:38:01 EDT 
Can we please eliminate italics from the HTML styler in the meantime?
It's pretty unusable in its current form (for a mouse clicker like me)
Comment 6 Mark Macdonald CLA 2011-05-04 13:03:41 EDT 
(In reply to comment #5)
> Can we please eliminate italics from the HTML styler in the meantime?
> It's pretty unusable in its current form (for a mouse clicker like me)

Ok, done in http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=27ceac642620c431c258212ea2f7a722c5155cf1

NB. I had to clear my cache before the italics would go away. Chrome seemed very aggressive about caching that CSS file -- not sure why.
Comment 7 Felipe Heidrich CLA 2011-05-04 14:25:15 EDT 
(In reply to comment #6)
> (In reply to comment #5)
> > Can we please eliminate italics from the HTML styler in the meantime?
> > It's pretty unusable in its current form (for a mouse clicker like me)
> Ok, done in
> http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=27ceac642620c431c258212ea2f7a722c5155cf1


Silenio and I are working on a change that make italic,bold, bold-italic work without variable line height. We plan the release the change this week (Bug 342973.


> NB. I had to clear my cache before the italics would go away. Chrome seemed
> very aggressive about caching that CSS file -- not sure why.

I hear you, and it is not only Chrome...
Comment 8 Silenio Quarti CLA 2011-05-06 15:40:25 EDT 
We add support for bold,italic,bold|italic styling.

Fixed
http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=72cb95a23a0216ca2d89974ea81d212f30da002f