Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344582 - [Decorators] Can't do colour decoration when using non-default decoration context
Summary: [Decorators] Can't do colour decoration when using non-default decoration con...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 10:17 EDT by Igor Fedorenko CLA
Modified: 2019-11-14 02:14 EST (History)
4 users (show)

See Also:


Attachments
trivial rcp application that demonstrates the problem (10.03 KB, application/zip)
2011-05-03 10:17 EDT, Igor Fedorenko CLA
no flags Details
proposed fix (9.84 KB, patch)
2011-05-03 10:45 EDT, Igor Fedorenko CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Fedorenko CLA 2011-05-03 10:17:15 EDT
Created attachment 194584 [details]
trivial rcp application that demonstrates the problem

I am using DecoratingStyledCellLabelProvider with IDecoratorManager.getLabelDecorator to allow thirdparty plugins add text and colour decorations to elements displayed in my view. Everything works as expected if I only use default/null decoration context. Colour decoration does not work if decorations are applied based on properties of non-default decoration context. Attached is a trivial RCP application that demonstrates the problem.
Comment 1 Igor Fedorenko CLA 2011-05-03 10:45:56 EDT
Created attachment 194593 [details]
proposed fix

Attached find proposed fix to allow colour decoration when using non-default decoration context. I realize this is stretching it, but it would be nice to see this addressed in 3.7 or at least know in advance it will not be addressed, so we can prepare plan "B".


Also, looking at the code I believe font and icon decoration code suffers from the same problem. Although we do not currently needs this functionality, I'll be happy to provide new version of the patch that covers fonts and icons... if it makes inclusion in 3.7 more likely ;-)
Comment 2 Dani Megert CLA 2011-05-03 12:04:28 EDT
I'd say it's too late given we're already in RC1.
Comment 3 Lars Vogel CLA 2019-11-14 02:14:57 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.