Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344578 - [Tooling] Rename checkbox to select servlet/entrypoint/application
Summary: [Tooling] Rename checkbox to select servlet/entrypoint/application
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Tools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4 RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 10:04 EDT by Holger Staudacher CLA
Modified: 2011-05-06 03:33 EDT (History)
0 users

See Also:


Attachments
Screenshot (84.54 KB, image/png)
2011-05-03 10:05 EDT, Holger Staudacher CLA
no flags Details
Screenshot of drop-down menu (28.50 KB, image/png)
2011-05-04 06:59 EDT, Rüdiger Herrmann CLA
no flags Details
filter moved to the drop-down menu (22.82 KB, patch)
2011-05-05 06:24 EDT, Beyhan Veliev CLA
holger.staudacher: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2011-05-03 10:04:57 EDT
Currently we provide a selection dialog in our launcher to let the user select an entrypoint or an application. We provide a similar dialog to select servlets. 
There is a checkbox that says "Only show from workspace". Per default the dialog shows all matches from the target and the workspace. I think this is confusing for new users. We should rename the checkbox to "Include target" and show only matches form the workspace by default.

I will attach a screenshot of the dialog I talk about.
Comment 1 Holger Staudacher CLA 2011-05-03 10:05:19 EDT
Created attachment 194583 [details]
Screenshot
Comment 2 Rüdiger Herrmann CLA 2011-05-03 10:14:47 EDT
I hope this is not too off-topic, but isn't the usual location for such options the drop-down menu that is located top-right to the search text field? E.g. Mylyn shows the "Show Completed Tasks" option there.
Comment 3 Rüdiger Herrmann CLA 2011-05-04 06:59:40 EDT
Created attachment 194694 [details]
Screenshot of drop-down menu

The screenshot shows the drop-down menu that could host the "Include extensions from target platform" option and thereby replace the checkbox at the bottom of the selection dialog.
Comment 4 Beyhan Veliev CLA 2011-05-05 06:19:36 EDT
>Per default the dialog shows all matches from the target and the workspace. I think this is confusing for new users.
Well I agree that for a newcomer the default value is confusing. My intention was to provide more information but sometimes less is more :).
>I hope this is not too off-topic, but isn't the usual location for such options the drop-down menu that is located top-right to the search text field?
Yes, it is. I agree that the drop-down menu is the usual place for this action. A doubt that a newcomer will find it but in the other hand a newcomer is also not interested in the target's servlets and entripoints/applications.
Comment 5 Beyhan Veliev CLA 2011-05-05 06:24:20 EDT
Created attachment 194812 [details]
filter moved to the drop-down menu

This patch:
* removes the check box "Only show from workspace" 
* adds a drop-down menu action "Include target"
* persists the state of the "Include target" action

I also did some code formatting ( removed "finals", correct some missing white spaces, ...)
Comment 6 Holger Staudacher CLA 2011-05-06 03:33:43 EDT
I reviewed the patch together with Beyhan and we did some refactoring. The changes are now in CVS HEAD. Good Job!