Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344554 - Remove property doesnt works after edit
Summary: Remove property doesnt works after edit
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Ankur Sharma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 07:35 EDT by Ankur Sharma CLA
Modified: 2011-05-16 16:46 EDT (History)
1 user (show)

See Also:
ankur_sharma: review+

Attachments
patch (1.33 KB, patch)
2011-05-05 06:56 EDT, Ankur Sharma CLA 		no flags Details | Diff
Improved Fix (2.29 KB, patch)
2011-05-05 16:17 EDT, Curtis Windatt CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ankur Sharma CLA 2011-05-03 07:35:40 EDT 
I20110428-0848

1. Create a Product Configuration and goto Configuration page
2. Click Add button and add a property
3. Select the entry and click Edit button. Change the property name. Click OK
4. Now click the Remove button. The entry will not delete.
Comment 1 Ankur Sharma CLA 2011-05-05 06:56:36 EDT 
Created attachment 194813 [details]
patch

Curtis, consider it for RC1
Comment 2 Curtis Windatt CLA 2011-05-05 16:14:38 EDT 
-1 when editing the item is removed from the tree which is confusing and then the selection is lost.  I will attach a better patch.
Comment 3 Curtis Windatt CLA 2011-05-05 16:17:38 EDT 
Created attachment 194879 [details]
Improved Fix
Comment 4 Curtis Windatt CLA 2011-05-05 16:20:50 EDT 
Ankur, please review the updated patch.  Only problem I see is the blink caused by removing/adding the item during table refresh.  A better solution would require redesigning how the properties are stored in the product.
Comment 5 Ankur Sharma CLA 2011-05-09 11:19:48 EDT 
+1

Applied to HEAD
Comment 6 Curtis Windatt CLA 2011-05-16 16:46:36 EDT 
Verified in I20110514-0800