Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344544 - Javadoc for method type parameters should not be generated if 'Ignore method type parameters' is disabled
Summary: Javadoc for method type parameters should not be generated if 'Ignore method ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 05:46 EDT by Dani Megert CLA
Modified: 2019-01-31 13:01 EST (History)
2 users (show)

See Also:
daniel_megert: review+

Attachments
Fix (1.63 KB, patch)
2011-05-10 12:45 EDT, Markus Keller CLA 		no flags Details | Diff
Fix 2 (5.62 KB, patch)
2011-05-10 12:51 EDT, Markus Keller CLA 		no flags Details | Diff
Test updates (687 bytes, patch)
2011-05-10 16:08 EDT, Markus Keller CLA 		no flags Details | Diff
Complete Patch with Tests (11.17 KB, patch)
2011-05-11 06:20 EDT, Markus Keller CLA 		daniel_megert: review+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-05-03 05:46:38 EDT 
3.7 M7.

The Javadoc generation for 'Add all missing tags' quick fix and 'Generate Element Comment' (Alt+Shift+J) should not add the tags for type parameters if 'Ignore method type parameters' is disabled (default).
Comment 1 Markus Keller CLA 2011-05-10 12:45:21 EDT 
Created attachment 195246 [details]
Fix

The 'Ignore method type parameters' is new in 3.7. It would make sense to fully support this and avoid generating unwanted tags.
Comment 2 Markus Keller CLA 2011-05-10 12:51:12 EDT 
Created attachment 195247 [details]
Fix 2

First patch was incomplete.
Comment 3 Markus Keller CLA 2011-05-10 12:51:38 EDT 
Dani, OK for RC1?
Comment 4 Markus Keller CLA 2011-05-10 16:08:30 EDT 
Created attachment 195271 [details]
Test updates
Comment 5 Markus Keller CLA 2011-05-11 06:20:18 EDT 
Created attachment 195321 [details]
Complete Patch with Tests

The patch with the test updates was not complete. Here's the complete all-in-one. Code changes are the same as in Fix 2.
Comment 6 Dani Megert CLA 2011-05-11 06:40:03 EDT 
+1 for RC1.
Comment 7 Markus Keller CLA 2011-05-11 07:06:45 EDT 
Fixed in HEAD.
Comment 8 Deepak Azad CLA 2011-05-16 02:29:56 EDT 
Verified with I20110512-2000.
Comment 9 Dani Megert CLA 2019-01-31 13:01:24 EST 
*** Bug 543183 has been marked as a duplicate of this bug. ***