Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344535 - [generator] LanguageConfig file extension check too strict
Summary: [generator] LanguageConfig file extension check too strict
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 04:07 EDT by Knut Wannheden CLA
Modified: 2017-10-31 11:16 EDT (History)
0 users

See Also:
sven.efftinge: kepler+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Wannheden CLA 2011-05-03 04:07:54 EDT 
LanguageConfig#checkConfiguration() checks the language's file extensions based on #isCheckFileExtension() (which can't be set using a property, but must be handled in a subclass). The check seems a bit too strict however. For instance it does not allow for URI encoded characters (e.g. ' ' -> '%20').
Comment 1 Sven Efftinge CLA 2012-11-21 04:45:06 EST 
I don't think whitespace is allowed in a file extension. However I've introduced a property to disable the check for people who think they know what they do :-)
Comment 2 Knut Wannheden CLA 2012-11-21 06:47:36 EST 
Great, thanks!

Spaces in the file extension is indeed odd. But EMF URIs and Eclipse's IResource and IPath seem to have no problem with that.
Comment 3 Eclipse Webmaster CLA 2017-10-31 11:05:18 EDT 
Requested via bug 522520.

-M.
Comment 4 Eclipse Webmaster CLA 2017-10-31 11:16:39 EDT 
Requested via bug 522520.

-M.