Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344490 - [editor] No animation while holding pageup/down in firefox
Summary: [editor] No animation while holding pageup/down in firefox
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 13:18 EDT by Andrew Niefer CLA
Modified: 2011-09-01 11:42 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2011-05-02 13:18:50 EDT
Using Firefox 4.0 on linux, I go to 
http://localhost:8080/coding.html#http://localhost:8080/file/A/org.eclipse.orion.dojo/static/orion.js.uncompressed.js

This file has 23k lines.

Press and hold page down, the screen moves once and then remains still.  Release the page down button and (after a brief pause) the editor moves to the new location a few thousand lines down.

This works nicely in Chrome.
Comment 1 Felipe Heidrich CLA 2011-05-03 15:05:55 EDT
> This works nicely in Chrome.

Not 100%, on Windows with Chrome 11 if you hold page down (or up) long enough sometimes the editor does not redraw all the pages. Definitely not as critical as on Firefox but also bad as it gives the impression the editor is slow.


The fix for both problems is the same, during scrolling just set the scrollTop and scrollLeft properties on the div and wait for the scroll event to update the page (the current code is forcing updatePage to run immeditally).
Comment 2 Felipe Heidrich CLA 2011-05-03 15:06:47 EDT
McQ has also pointed out this problem to SSQ.
Comment 3 Felipe Heidrich CLA 2011-05-03 15:14:26 EDT
Fixed

http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=6ef4757999f2ce0f35471a9f1f656f069c5d321e

Simon&Andrew, please try with the latest
Comment 4 Andrew Niefer CLA 2011-05-03 15:37:58 EDT
(In reply to comment #1)
> > This works nicely in Chrome.
> 
> Not 100%, on Windows with Chrome 11 if you hold page down (or up) long enough
> sometimes the editor does not redraw all the pages. Definitely not as critical
> as on Firefox but also bad as it gives the impression the editor is slow.

I am seeing this as well, holding the key down long enough does slow down the redraw eventually.

Still trying to update to the new change to try it out, Orion seems broken in my current state.