Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344489 - NPE in PlatformUiUtil.supportsMultipleHyperlinkPresenter causing bugzilla to fail to load and error dialog
Summary: NPE in PlatformUiUtil.supportsMultipleHyperlinkPresenter causing bugzilla to ...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 3.6   Edit
Assignee: Shawn Minto CLA
QA Contact: Frank Becker CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 13:01 EDT by Shawn Minto CLA
Modified: 2011-05-09 22:18 EDT (History)
1 user (show)

See Also:

Attachments
patch (1.33 KB, patch)
2011-05-02 13:02 EDT, Shawn Minto CLA 		eclipse: iplog+
Details | Diff
patch V2 (1.40 KB, patch)
2011-05-02 14:03 EDT, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (5.31 KB, application/octet-stream)
2011-05-02 14:03 EDT, Frank Becker CLA 		no flags Details
patch V3 (1.32 KB, patch)
2011-05-05 16:56 EDT, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (24.40 KB, application/octet-stream)
2011-05-05 16:56 EDT, Frank Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2011-05-02 13:01:18 EDT 
When the org.eclipse.platform bundle is not included with an RCP product on MAC, users are unable to use the bugzilla connector due to an NPE in the constructor.

Caused by: java.lang.NullPointerException
	at org.eclipse.mylyn.internal.provisional.commons.ui.PlatformUiUtil.supportsMultipleHyperlinkPresenter(PlatformUiUtil.java:145)
	at org.eclipse.mylyn.internal.bugzilla.ui.tasklist.BugzillaConnectorUi.<init>(BugzillaConnectorUi.java:73)
Comment 1 Shawn Minto CLA 2011-05-02 13:02:24 EDT 
Created attachment 194512 [details]
patch

Here is a potential patch to the commons project
Comment 2 Frank Becker CLA 2011-05-02 14:03:09 EDT 
Created attachment 194519 [details]
patch V2

Shawn,

can you please verify my changes.

I think it is better to assume that the MultipleHyperlinkPresenter is not present.
Comment 3 Frank Becker CLA 2011-05-02 14:03:11 EDT 
Created attachment 194520 [details]
mylyn/context/zip
Comment 4 Shawn Minto CLA 2011-05-03 19:26:46 EDT 
That looks good to me.
Comment 5 Frank Becker CLA 2011-05-04 14:03:21 EDT 
patch V2 is now in HEAD
Comment 6 Steffen Pingel CLA 2011-05-04 18:07:05 EDT 
Which is the bundle that provides the multiple hyper link support? We should check the version of that exact bundle if it's not the org.eclipse.platform bundle.
Comment 7 Frank Becker CLA 2011-05-05 16:56:24 EDT 
Created attachment 194883 [details]
patch V3

(In reply to comment #6)
> Which is the bundle that provides the multiple hyper link support? We should
> check the version of that exact bundle if it's not the org.eclipse.platform
> bundle.

Please see bug# 322293 . The bundle is org.eclipse.swt but I did not know what version of org.eclipse.swt was used in eclipse platform 3.7.0.v201101192000. When I look in the cvs repository I think that this is v3721. Can someone verify this? 

the actual eclipse platform version   3.7.0.v201103101119 use swt 3.7.0.v3724c
Comment 8 Frank Becker CLA 2011-05-05 16:56:27 EDT 
Created attachment 194884 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2011-05-05 17:15:19 EDT 
That's fine with me. Seems most important that we properly differentiate recognize <= 3.6.2 and >= 3.7 here.

Please change the TODO comment to the standard format so we can find it when approriate: //TODO e3.7 change this to.... Otherwise please feel free to commit.
Comment 10 Frank Becker CLA 2011-05-06 14:36:19 EDT 
patch V3 is now in head. See comment#9