Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344446 - [Intro] BIDI: BDL_Welcome page is not mirrored
Summary: [Intro] BIDI: BDL_Welcome page is not mirrored
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Chris Austin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 08:58 EDT by amir CLA
Modified: 2011-05-16 13:22 EDT (History)
6 users (show)

See Also:
cgold: review+

Attachments
Welcome page is not mirrored (57.29 KB, image/jpeg)
2011-05-02 09:00 EDT, amir CLA 		no flags Details
Patch to fix welcome rtl text (606 bytes, patch)
2011-05-09 17:00 EDT, Chris Austin CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description amir CLA 2011-05-02 08:58:19 EDT 
Build Identifier: I20110310-1119

Welcome page is not mirrored when eclipse GUI is mirrored

Reproducible: Always

Steps to Reproduce:
When launch eclipse with -rtl option welcome page is not mirrored.
In addition, navigation arrows in toolbar are not mirrored
Comment 1 amir CLA 2011-05-02 09:00:12 EDT 
Created attachment 194481 [details]
Welcome page is not mirrored
Comment 2 Chris Goldthorpe CLA 2011-05-06 13:30:18 EDT 
Chris A, can you look into this, it may to be related to the change you made to Eclipse 3.7 for RTL.
Comment 3 Chris Austin CLA 2011-05-09 17:00:49 EDT 
Created attachment 195149 [details]
Patch to fix welcome rtl text

Yes - I noticed this in the backpatch for 3.6.2, but didn't catch it in 3.7.  The attached patch should take care of it.  Amir, can you confirm that this patch resolves the welcome rtl issue?  Note, this does not change the back/forward buttons - I think those are supposed to be as they are in the screenshot.
Comment 4 Chris Goldthorpe CLA 2011-05-09 17:45:13 EDT 
Targeting RC1 - please add me as a reviewer if you think this patch is ready to commit.
Comment 5 Chris Goldthorpe CLA 2011-05-10 13:07:55 EDT 
Patch is good but needed the copyright changed to 2011. I have updated the copyright and applied the patch.
Comment 6 Chris Goldthorpe CLA 2011-05-16 13:22:08 EDT 
Verified in : I20110512-2000.