Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344436 - [imports on paste] Allow to cancel 'Update imports on paste'
Summary: [imports on paste] Allow to cancel 'Update imports on paste'
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 07:20 EDT by Dani Megert CLA
Modified: 2011-05-16 06:58 EDT (History)
4 users (show)

See Also:
markus.kell.r: review+

Attachments
Fix (3.76 KB, patch)
2011-05-04 03:43 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-05-02 07:20:10 EDT 
3.7 M7.

Adding imports on paste can result in a search when it tries to resolve on-demand conflicts. When the search index is still built this results in a blocked UI, see e.g. bug 343837.
Comment 1 Dani Megert CLA 2011-05-04 03:43:54 EDT 
Created attachment 194670 [details]
Fix
Comment 2 Dani Megert CLA 2011-05-04 03:44:59 EDT 
Markus, please review the patch. +1 for RC1?
Comment 3 Markus Keller CLA 2011-05-05 05:28:32 EDT 
Fix is good. However, I would use getSite().getService(..) instead of getAdapter(..), as recommended by IWorkbenchSiteProgressService.
Comment 4 Dani Megert CLA 2011-05-05 05:53:59 EDT 
Committed my patch to HEAD.
Comment 5 Raksha Vasisht CLA 2011-05-16 06:58:59 EDT 
Verified for 3.7RC1 with  I20110514-0800.