Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344413 - Facet Columns are never created when we begin with an empty table
Summary: Facet Columns are never created when we begin with an empty table
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 03:14 EDT by Vincent Lorenzo CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: indigo+

Attachments
Patch for Bug 344413 (1.43 KB, patch)
2011-05-04 05:04 EDT, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
Patch for Bug 344413 UnitTest (14.33 KB, patch)
2011-05-06 04:42 EDT, Nicolas Guyomar CLA 		no flags Details | Diff
Patch for Bug 344413 UnitTest (17.93 KB, patch)
2011-05-09 04:46 EDT, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2011-05-02 03:14:17 EDT 
Facet columns are never created when we begin with an empty table. You can reproduce this bug with the table ecore example. 
In order to do that, please comment the line  : list.addAll(ePackage.getEClassifiers()); in EditAnEcoreModelHandler.java.  -> so, we can begin with an empty table.
	1/Select the EPackage and choose the action : "Open Ecore Tabular Editor"
	2/Drop an EClass in the table -> the facet columns are not created
	3/Go to "Load an EMF Facet" Action -> the facets are correctly applied.
Comment 1 Nicolas Guyomar CLA 2011-05-04 05:04:11 EDT 
Created attachment 194683 [details]
Patch for Bug 344413

Hi Vincent,

Indeed, only the customizations where refreshed when a new element is added to the table.

In the attached patch, I've added the facets refresh before the customization's one.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 2 Vincent Lorenzo CLA 2011-05-04 05:29:23 EDT 
(In reply to comment #1)
  Hi Nicolas, 
    your patch works fine, thank you.
   
  Regards, 
  Vincent Lorenzo
Comment 3 Nicolas Guyomar CLA 2011-05-06 04:42:39 EDT 
Created attachment 194910 [details]
Patch for Bug 344413 UnitTest

Hi,

Please find attached a non regression test based on the given scenario.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 4 Nicolas Guyomar CLA 2011-05-09 04:46:22 EDT 
Created attachment 195044 [details]
Patch for Bug 344413 UnitTest

Hi,

Please find attached a updated non regression test based on the given scenario.
There were 2 java classes missing in the previous one, those classes were referenced in test facets.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 5 Gregoire Dupe CLA 2011-05-09 05:52:59 EDT 
Comment on attachment 194683 [details]
Patch for Bug 344413

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 637.
Comment 6 Gregoire Dupe CLA 2011-05-09 05:53:30 EDT 
Comment on attachment 195044 [details]
Patch for Bug 344413 UnitTest

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 637.
Comment 7 Gregoire Dupe CLA 2011-05-09 05:53:56 EDT 
This bug can be marked as fixed.
Comment 8 Vincent Lorenzo CLA 2011-05-20 09:45:12 EDT 
This bug can be marked as closed