Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344406 - [releng] Bad example plugin properties
Summary: [releng] Bad example plugin properties
Status: CLOSED FIXED
Alias: None
Product: OCL
Classification: Modeling
Component: Core (show other bugs)
Version: 3.1.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.1.0   Edit
Assignee: OCL Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-01 13:18 EDT by Ed Willink CLA
Modified: 2011-05-03 17:07 EDT (History)
1 user (show)

See Also:

Attachments
Patch updating the plugin.properties accordingly (5.73 KB, patch)
2011-05-01 13:48 EDT, Axel Uhl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-05-01 13:18:40 EDT 
Using Help->About Eclipse->Installation Details->Plugins shows very irregular results for the impact plugins. Correct plugin.properties. If the changes don't take make sure the manifest has Eclipse localization.
Comment 1 Axel Uhl CLA 2011-05-01 13:48:53 EDT 
Created attachment 194455 [details]
Patch updating the plugin.properties accordingly

Not sure if I need a +1 for this. Do I?
Comment 2 Ed Willink CLA 2011-05-01 14:20:33 EDT 
No. They're your examples. This was one of the few respects in which they have a public imprint.
Comment 3 Axel Uhl CLA 2011-05-01 16:05:07 EDT 
Committed to CVS HEAD
Comment 4 Ed Willink CLA 2011-05-03 12:26:30 EDT 
In M7, impactanalyzer.util and impactanalyzer.ui are still a problem.
Comment 5 Axel Uhl CLA 2011-05-03 16:07:56 EDT 
Here are the .util and .ui build.properties in their 1.1 revision:


# <copyright>
# </copyright>
#
# $Id: plugin.properties,v 1.1 2011/05/01 20:04:58 auhl Exp $

pluginName = OCL Impact Analyzer Utilities
providerName = Eclipse Modeling Project


and


# <copyright>
# </copyright>
#
# $Id: plugin.properties,v 1.1 2011/05/01 20:05:00 auhl Exp $

pluginName = OCL Impact Analyzer UI Integration
providerName = Eclipse Modeling Project


respectively. Closing again. Maybe you're on the wrong revision?
Comment 6 Ed Willink CLA 2011-05-03 16:37:57 EDT 
I'm looking at M7. There is alot more than just plugin.properties.

See the orignal report "If the changes don't
take make sure the manifest has Eclipse localization."
Comment 7 Axel Uhl CLA 2011-05-03 17:07:55 EDT 
(In reply to comment #6)
> I'm looking at M7. There is alot more than just plugin.properties.
> 
> See the orignal report "If the changes don't
> take make sure the manifest has Eclipse localization."

Ah, fixed by adding

Bundle-Localization: plugin


to the MANIFEST.MF files of

org.eclipse.ocl.examples.impactanalyzer.tests
org.eclipse.ocl.examples.impactanalyzer.testutils
org.eclipse.ocl.examples.impactanalyzer.util
org.eclipse.ocl.examples.impactanalyzer.ui