Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344345 - Clones view shows the clones of all users
Summary: Clones view shows the clones of all users
Status: VERIFIED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 critical (vote)
Target Milestone: 0.2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-29 16:25 EDT by John Arthorne CLA
Modified: 2011-09-01 11:41 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-04-29 16:25:39 EDT 
0.2 M7

If one user creates a clone, all users on the same server can see the clone in their clones list. If I try to link another user's clone to my workspace, an error occurs but there is no indication of failure to the user.

A user should only see their own clones!
Comment 2 John Arthorne CLA 2011-04-29 17:13:23 EDT 
Tomasz please double-check the fix when you get back.
Comment 3 Tomasz Zarna CLA 2011-05-02 09:38:15 EDT 
Looks good. Added tests and modified GitCloneHandlerV1 a little bit so it returns 404 if a user calls GET on another user's clone[1].

[1] http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=f4689d2c598343cace8ccfec971b8855db64c7bc