Community
Participate
Working Groups
Build Identifier: If I navigate to: http://www.eclipse.org/orion/ Using Firefox 3.6.16 on Windows 7 the undo/redo buttons do not work. John Arthorne also confirms it does not work for him using Windows 7, Chrome 11 Setting severity to critical because it is darned embarrassing. Feel free to downgrade :-) Reproducible: Always
Nathan, have these buttons ever worked? Note that Ctrl-Z and Ctrl-Y don't work either. I think the answer to this is to embed the editorContainer now that bug 337647 is completed. Nathan, there is an example, http://localhost:8080/examples/minimaleditor.html, that shows how this works. I plan to update this example to use prettier visuals, and I would hope you could base the embedded landing page editor on this.
Yes those buttons used to work, thanks for reporting this. Totally agree, having a minimal editor is a good thing, I should migrate Orion to its code.
(In reply to comment #2) > Yes those buttons used to work, thanks for reporting this. > > Totally agree, having a minimal editor is a good thing, I should migrate Orion > to its code. Nathan, see bug 340926. I now have an html page that embeds an editor with js, java, and css syntax highlighting, and keyword content assist for css and js. Undo and redo are working in this example (though I have not placed buttons in the toolbar for it). The example puts a "save" link in the top editor bar, but you could just as easily put undo, redo, or whatever else you want there. I think this should be the basis for embedding the editor and can work with you on any questions or problems you encounter.
Created attachment 194848 [details] mockup of landing page with embedded editor While working on the "skinny header" for the embedded editor case, our designer did a mockup of the landing page to show what it looks like in context. She also suggested using a dark border around the embedded editor to fit with the header visual, you can do what you want with this idea....
Nathan, if you want to show off HTML syntax highlighting, you can use the plugin - org.eclipse.orion.client.core/static/plugins/htmlSyntaxHighlightPlugin.html
I attempted to update the editor today loosely following the instructions at http://wiki.eclipse.org/Orion/How_Tos/Setup_Orion_Client_Hosted_Site_on_OrionHub with little success. For a minimal editor I found the requirement in order to get this working to be quite the opposite. Having to include /org.eclipse.orion.client.core/static /org.eclipse.orion.client.editor/web as well as dojo locally does not seem minimal to me. In the mean time i've removed the undo buttons.
(In reply to comment #6) > I attempted to update the editor today loosely following the instructions at > http://wiki.eclipse.org/Orion/How_Tos/Setup_Orion_Client_Hosted_Site_on_OrionHub > with little success. > > For a minimal editor I found the requirement in order to get this working to be > quite the opposite. Having to include > /org.eclipse.orion.client.core/static > /org.eclipse.orion.client.editor/web > as well as dojo locally does not seem minimal to me. That how-to is for folks who want to run any part of the orion client in an environment hosted on orion hub. For the editor case, you don't need all of those files, but you do need... <script src="/editor/samples/styler.js"></script> <script src="/editor/samples/rulers.js"></script> <script src="/editor/samples/undoStack.js"></script> <script src="/editor/js/model.js"></script> <script src="/editor/js/editor.js"></script> <script src="/js/editorFeatures.js"></script> <script src="/js/contentAssist.js"></script> <script src="/js/contentAssist/coreContentAssist.js"></script> <script src="/js/editorContainer.js"></script> <script src="/examples/embeddededitor.js"></script> The big issue here is dojo. I opened bug 345472 because I think our references to dojo in the latter 5 files is fairly random and we could make an effort to stop using dojo convenience methods in these files.
Sorry Dean -- downgrading ;) Not that's it not embarrassing but it's not preventing a release (and keeps on freaking me out when I triage). Could you take a look again to see if the minimal editor is now a sufficiently good example to get this working.
We need to update the editor here.
So this is moot now that we've currently removed the editor from the page.
