Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344295 - refine proxy marketplaces for DnD
Summary: refine proxy marketplaces for DnD
Status: RESOLVED FIXED
Alias: None
Product: MPC
Classification: Technology
Component: wizard (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 critical (vote)
Target Milestone: 1.1.1   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-29 11:17 EDT by Benjamin Muskalla CLA
Modified: 2011-07-22 07:30 EDT (History)
1 user (show)

See Also:


Attachments
patch (7.48 KB, patch)
2011-05-01 10:30 EDT, Benjamin Muskalla CLA
no flags Details | Diff
mylyn/context/zip (123.94 KB, application/octet-stream)
2011-05-01 10:30 EDT, Benjamin Muskalla CLA
no flags Details
proposed patch (7.48 KB, patch)
2011-05-03 11:30 EDT, Benjamin Muskalla CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2011-04-29 11:17:28 EDT
Due to the cleanup of local marketplaces, we don't have the information anymore which url points to a valid marketplace. As marketplaces are retrieved on wizard start, the DnD ignores dropped links.

My suggestions is to fire up the wizard in any case (if mpc_install is present) and handle if we have a proper marketplace for this.
Comment 1 Benjamin Muskalla CLA 2011-05-01 10:30:16 EDT
Created attachment 194449 [details]
patch

Suggested solution. We now pass a descriptor hint into the marketplace wizard to resolve it later on in the lifecycle. While it would make most sense to implement the hint as another flavor of the descriptor, I too much like the idea of having the descriptor being final.
Comment 2 Benjamin Muskalla CLA 2011-05-01 10:30:21 EDT
Created attachment 194450 [details]
mylyn/context/zip
Comment 3 Benjamin Muskalla CLA 2011-05-03 11:30:17 EDT
Created attachment 194602 [details]
proposed patch

Here is the proposal. It essentially replaces the catalog descriptor with a hint descriptor and resolves it later.
Comment 4 Benjamin Muskalla CLA 2011-05-12 08:51:35 EDT
The proposed patch was commited to master for M7. We still should think about if there is a cleaner solution for this.
Comment 5 Benjamin Muskalla CLA 2011-07-20 23:27:23 EDT
I think we're done here.