Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 344261 - GEM views infinitely recurse on themselves during activation on 4.x
Summary: GEM views infinitely recurse on themselves during activation on 4.x
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: GEM (show other bugs)
Version: 5.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Alan Humphrey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 344260
  Show dependency tree
 
Reported: 2011-04-29 08:25 EDT by Remy Suen CLA
Modified: 2011-05-21 09:45 EDT (History)
2 users (show)

See Also:

Attachments
Patch for bug 344261 (6.57 KB, patch)
2011-05-17 13:29 EDT, Alan Humphrey CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-04-29 08:25:43 EDT 
The 'GEM Analyzer', 'GEM Browser', and 'GEM Console' all have bad implementations of the setFocus() method.

The setFocus() method is meant for the client to set focus on one of its child controls, not for it to start requesting an activation to a part. Please change the implementation to grant focus to one of its controls.

The workbench also guarantee that setFocus() will be called from a UI thread so it's not clear to me why the "We need to switch to the thread that is allowed to change the UI" comment (and subsequent code) was needed here.
Comment 1 Alan Humphrey CLA 2011-05-17 11:45:01 EDT 
Remy,

Thanks. I will have this fixed today and apply to PTP HEAD. I believe the 4.07 build has already happened, but will also apply fix to ptp_4* branch as well.

-Alan
Comment 2 Alan Humphrey CLA 2011-05-17 13:29:50 EDT 
Created attachment 195896 [details]
Patch for bug 344261

Patch to replace GEM's incorrect setFocus() implementations.
Comment 3 Alan Humphrey CLA 2011-05-17 14:08:44 EDT 
Applied patch to HEAD and ptp_4_0 branch.